Closed Bug 1081050 Opened 10 years ago Closed 10 years ago

Intermittent calendar/test/unit/day_observer_test.js | "after each" hook - TypeError: this.connection is null (app://calendar.gaiamobile.org/js/db.js?time=1412932298308:155)

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cbook, Assigned: mmedeiros)

References

()

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

b2g_ubuntu64_vm mozilla-inbound opt test gaia-unit

https://treeherder.mozilla.org/ui/logviewer.html#?job_id=2905770&repo=mozilla-inbound

02:11:39 INFO - TEST-UNEXPECTED-FAIL | calendar/test/unit/day_observer_test.js | "after each" hook - TypeError: this.connection is null (app://calendar.gaiamobile.org/js/db.js?time=1412932298308:155)
OS: Mac OS X → Gonk (Firefox OS)
I have a hunch that this was caused by bug 1065520.
Blocks: 1065520
Assignee: nobody → mmedeiros
was able to reproduce it locally by running "day_obeserver_test.js" 10x in a row (wrapped whole suite on a while loop).. This small change should fix the race condition (was adding listener before calling `sinon.useFakeTimers()`)
Attachment #8504276 - Flags: review?(gaye)
Comment on attachment 8504276 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25095

LGTM and thanks for fixing Miller!
Attachment #8504276 - Flags: review?(gaye) → review+
https://github.com/mozilla-b2g/gaia/commit/ad22d7e535793d2cb7056d9a45f8153aaca767be landed on master
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: