Closed
Bug 1081083
Opened 11 years ago
Closed 11 years ago
Add getSelectedCell method in widgets.js
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(firefox32 wontfix, firefox33 fixed, firefox34 fixed, firefox35 fixed, firefox36 fixed, firefox-esr31 fixed)
People
(Reporter: danisielm, Assigned: danisielm)
References
Details
(Whiteboard: [lib][lang=js][sprint])
Attachments
(2 files, 2 obsolete files)
We need for bug 996530 a getSelectedCell() method to get the selected cell from a tree.
Let's add this (across all branches) and we can also include it in the class we'll create in bug 1016246.
|
Assignee | |
Updated•11 years ago
|
status-firefox32:
--- → affected
status-firefox33:
--- → affected
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox-esr31:
--- → affected
|
|
Assignee | |
Comment 1•11 years ago
|
||
Here is the method.
Attachment #8503104 -
Flags: review?(andrei.eftimie)
Attachment #8503104 -
Flags: review?(andreea.matei)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8503104 [details] [diff] [review]
v1.patch
Review of attachment 8503104 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm, with the added item in the jsdoc section, ask a review from Henrik please.
::: lib/ui/widgets.js
@@ +46,5 @@
> +/**
> + * Get the selected Cell
> + *
> + * @param {MozElement} aTree
> + * Element tree to operate on
Please add a @return statement
Attachment #8503104 -
Flags: review?(andrei.eftimie)
Attachment #8503104 -
Flags: review?(andreea.matei)
Attachment #8503104 -
Flags: review+
|
|
||
Updated•11 years ago
|
Whiteboard: [lib][lang=js] → [lib][lang=js][sprint]
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8503104 -
Attachment is obsolete: true
Attachment #8504706 -
Flags: review?(hskupin)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8504706 [details] [diff] [review]
v1.1.patch
Review of attachment 8504706 [details] [diff] [review]:
-----------------------------------------------------------------
::: lib/ui/widgets.js
@@ +59,3 @@
> // Export of functions
> exports.clickTreeCell = clickTreeCell;
> +exports.getSelectedCell = getSelectedCell;
We should actually get this all into a Tree class. Please file a mentored bug for that.
Attachment #8504706 -
Flags: review?(hskupin) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #4)
> Comment on attachment 8504706 [details] [diff] [review]
> v1.1.patch
>
> Review of attachment 8504706 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: lib/ui/widgets.js
> @@ +59,3 @@
> > // Export of functions
> > exports.clickTreeCell = clickTreeCell;
> > +exports.getSelectedCell = getSelectedCell;
>
> We should actually get this all into a Tree class. Please file a mentored
> bug for that.
Hey, there is already one filed: bug 1016246.
|
|
Assignee | |
Comment 6•11 years ago
|
||
Comment on attachment 8504706 [details] [diff] [review]
v1.1.patch
Applies cleanly on default, aurora, beta and release.
Attachment #8504706 -
Flags: checkin?(andrei.eftimie)
|
|
Assignee | |
Comment 7•11 years ago
|
||
Patch for esr31.
Attachment #8505293 -
Flags: checkin?(andrei.eftimie)
|
|
Assignee | |
Updated•11 years ago
|
status-firefox36:
--- → affected
|
|
Assignee | |
Comment 8•11 years ago
|
||
Removed extra space.
Attachment #8505293 -
Attachment is obsolete: true
Attachment #8505293 -
Flags: checkin?(andrei.eftimie)
Attachment #8505294 -
Flags: review?(andrei.eftimie)
Attachment #8505294 -
Flags: review?(andreea.matei)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8505294 -
Flags: checkin?
|
|
||
Comment 9•11 years ago
|
||
Comment on attachment 8504706 [details] [diff] [review]
v1.1.patch
Review of attachment 8504706 [details] [diff] [review]:
-----------------------------------------------------------------
remote: https://hg.mozilla.org/qa/mozmill-tests/rev/3c0b8bae9dff (default)
remote: https://hg.mozilla.org/qa/mozmill-tests/rev/db66d5f1b849 (mozilla-aurora)
remote: https://hg.mozilla.org/qa/mozmill-tests/rev/6a0c5891f286 (mozilla-beta)
remote: https://hg.mozilla.org/qa/mozmill-tests/rev/fa55b5797aea (mozilla-release)
Attachment #8504706 -
Flags: checkin?(andrei.eftimie) → checkin+
|
|
||
Updated•11 years ago
|
|
|
||
Comment 10•11 years ago
|
||
Comment on attachment 8505294 [details] [diff] [review]
v1.2_esr31.patch
Review of attachment 8505294 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8505294 -
Flags: review?(hskupin)
Attachment #8505294 -
Flags: review?(andrei.eftimie)
Attachment #8505294 -
Flags: review?(andreea.matei)
Attachment #8505294 -
Flags: review+
Attachment #8505294 -
Flags: checkin?
|
|
||
Updated•11 years ago
|
Attachment #8505294 -
Flags: review?(hskupin) → review+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8505294 -
Flags: checkin?(andrei.eftimie)
|
|
||
Comment 11•11 years ago
|
||
Comment on attachment 8505294 [details] [diff] [review]
v1.2_esr31.patch
Review of attachment 8505294 [details] [diff] [review]:
-----------------------------------------------------------------
https://hg.mozilla.org/qa/mozmill-tests/rev/36d8bcd21096 (mozilla-esr31)
Attachment #8505294 -
Flags: checkin?(andrei.eftimie) → checkin+
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•