1081084 - XML with no stylesheet message doesn't show well on RTL

Status: RESOLVED FIXED

(Mozilla Localizations :: he / Hebrew, defect)

Description

[Tomer Cohen :tomer]

Attachment: Simple testcase

When requesting plain XML documents with no stylesheet, there is a message on the top indicating that there is no stylesheet attached. That message is aligned to the right side but is missing dir=rtl.

Comment 1

[Tomer Cohen :tomer]

Attachment: Screen Shot, Hebrew

The attached screenshot contains the actual result. Please note that the third word from the right should be XML. 

        זה אין מידע על סגנון המשויך אליו. עץ המסמך מוצג להלן XML נראה שלקובץ.

Comment 2

[Francesco Lodolo [:flod]]

I don't think this is the right product (it's not a bug in the localization, is it?).
Not sure if Core::XML makes sense.

Comment 3

[Tomer Cohen :tomer]

(In reply to Francesco Lodolo [:flod] from comment #2)
> I don't think this is the right product (it's not a bug in the localization,
> is it?).
> Not sure if Core::XML makes sense.

It isn't, you right. I am just placing it while investigating for what causing it in case it is not a problem on our locale. ☺

Comment 4

[Tomer Cohen :tomer]

According to [XMLPrettyPrint.xsl, line 22][1], we already have the code for RTL in the right location, but it doesn't work well enough. I suspect that the [source code viewer][2] is messing with the message. 


[1]: http://mxr.mozilla.org/mozilla-central/source/dom/xml/resources/XMLPrettyPrint.xsl#22
[2]: http://mxr.mozilla.org/mozilla-central/source/layout/style/viewsource.css#11

I forgot to mention previously that this problem affects only RTL locales, and the testcase above would show the problem only on each of these locales. A workaround could be injecting RLE on [xml.nostylesheet][3] for the affected locales.

[3]: http://mxr.mozilla.org/mozilla-central/source/dom/locales/en-US/chrome/xml/prettyprint.dtd

Comment 5

[Tomer Cohen :tomer]

https://pontoon.mozilla.org/he/firefox-aurora/all-resources/?search=This+XML+file+does+not+appear&string=69712
https://community.mozilla.org.il/viewtopic.php?f=16&t=12474#p61831

Could be that the at some point strings prefixed with RLE got garbled. I'm assigning this issue to myself while investigating.

Comment 6

[Tomer Cohen :tomer]

https://hg.mozilla.org/l10n-central/he/diff/7fa01a778f7c/dom/chrome/xml/prettyprint.dtd

Comment 7

[Itiel]

Seems to be fixed.
Closing as RESOLVED FIXED.