1081104 - [Setting] Duplicated key fdn-authorizedNumbers in settings.properties

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Francesco Lodolo [:flod]]

They're both quite old: one was added in bug 840915 (used in a link)
https://github.com/mozilla-b2g/gaia/commit/2d870100a945272824f8e42a8c52aac095fe907e

The other in bug 888912 (used as a header)
https://github.com/mozilla-b2g/gaia/commit/beca39db6c9c71e3578d025e1c4c57cde9993900

The last one is still used in the code
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/call_fdn_settings.html#L29-L31

The 1st one has been replaced by fdn-authorizedNumbers-header
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/elements/call_fdn_list.html#L5

So we can just removed one of the strings, no need to create a new one.

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Pull request removing one of the strings.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8503125 [details] [review]
Pull request on Github

Looks like a dup string, let' remove it !

Note: I just checked translated files in gaia-l10n and notice that we can find the dup string in some languages while the others are not.

Example : 

[Fr] - with dup
http://hg.mozilla.org/gaia-l10n/fr/file/e5dbc841cb81/apps/settings/settings.properties#l173
http://hg.mozilla.org/gaia-l10n/fr/file/e5dbc841cb81/apps/settings/settings.properties#l190

[Br] - without dup
http://hg.mozilla.org/gaia-l10n/br/file/d6f309b2e71b/apps/settings/settings.properties#l159

I am not sure whether this change would make l10n notice this,so let me ni? Axel for this change.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #2)
> I am not sure whether this change would make l10n notice this,so let me ni?

There's a simple explanation for that: people who work directly on files won't notice the duplicated key, tools will and they'll ignore the other instance (that's also true for l10n.js).

That's a big issue when the strings are different (it happened), not really when the strings are identical.

That's also why we plan to have a test for that (:gandalf found this while working on blockers for bug 1013831, it should be the last one).

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Francesco Lodolo [:flod] from comment #3)
> (In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #2)
> > I am not sure whether this change would make l10n notice this,so let me ni?
> 
> There's a simple explanation for that: people who work directly on files
> won't notice the duplicated key, tools will and they'll ignore the other
> instance (that's also true for l10n.js).

That's why I point out two examples about this problem and want to remind l10n team of dup strings in these locales and have to remove later.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to EJ Chen [:eragonj][:小龍哥][ni? if you need me] from comment #4)
> That's why I point out two examples about this problem and want to remind
> l10n team of dup strings in these locales and have to remove later.

True that, but since the en-US string is the same, translation is supposed to be the same (there are some exceptions). I'll send a message to dev-l10n
http://mxr.mozilla.org/l10n-gaia/search?string=fdn-authorizedNumbers%3D&find=&findi=&filter=^%5B^\0%5D*%24&hitlimit=&tree=l10n-gaia

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Francesco ! XD

Comment 7

[Carsten Book [:Tomcat]]

master : https://github.com/mozilla-b2g/gaia/commit/b164890e6ef94770be292b091e2def4d51f40fc0