1081134 - "let" is not handled properly in validator with spidermonkey

Status: RESOLVED FIXED

(Marketplace Graveyard :: Validation, defect, P3)

Description

[Mathieu Pillard [:mat]]

When running the tests with spidermonkey [0], the following test fails:

tests.js.test_scope:TestScope.test_function_scope_block

The code tested works fine in a spidermonkey shell. Furthermore, moving the "let" declaration in that test inside the inner function works, so something somewhere is not properly binding "let" variables (Validator or Spidermonkey). If we look at the debug output we see that when it seeks for the variable "x" it doesn't find it, even though it should.

This could indicate a greater issue with the handing of "let" in the validator, and some developers do use it in their apps, so we should look into it.


[0] "let" tests are skipped on acorn so this test isn't failing on travis.

Comment 1

[Mathieu Pillard [:mat]]

Fixed in app-validator in https://github.com/mozilla/app-validator/commit/ebedd9d8fbde816945ecceb1704ebbd9f4e5dee0. Thanks, :bbouvier!

I'm not updating zamboni to point to the new validator yet, I prefer to wait for next push so that we get more time testing with real apps.