Closed Bug 1081160 Opened 6 years ago Closed 6 years ago

[10.10] Update window shadows

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
firefox33 --- wontfix
firefox34 --- fixed
firefox35 --- fixed
firefox36 --- fixed

People

(Reporter: mstange, Assigned: mstange)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This makes tooltip and context menu shadows look native on 10.10.
Attachment #8503212 - Flags: review?(smichaud)
Comment on attachment 8503212 [details] [diff] [review]
patch

My eyes aren't much good for this kind of thing.  But I'll take your word for it :-)
Attachment #8503212 - Flags: review?(smichaud) → review+
https://hg.mozilla.org/mozilla-central/rev/47ac4791adf3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Markus, this looks upliftable to me, would you agree? :-)
Flags: needinfo?(mstange)
Comment on attachment 8503212 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Yosemite visuals
[User impact if declined]: menu and tooltip shadows look off
[Describe test coverage new/current, TBPL]: none
[Risks and why]: extremely low, very simple patch
[String/UUID change made/needed]: none
Flags: needinfo?(mstange)
Attachment #8503212 - Flags: approval-mozilla-beta?
Attachment #8503212 - Flags: approval-mozilla-aurora?
Comment on attachment 8503212 [details] [diff] [review]
patch

Beta+
Aurora+
Attachment #8503212 - Flags: approval-mozilla-beta?
Attachment #8503212 - Flags: approval-mozilla-beta+
Attachment #8503212 - Flags: approval-mozilla-aurora?
Attachment #8503212 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.