[10.10] Update window shadows

RESOLVED FIXED in Firefox 34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

(Blocks 1 bug)

Trunk
mozilla36
All
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox33 wontfix, firefox34 fixed, firefox35 fixed, firefox36 fixed)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
This makes tooltip and context menu shadows look native on 10.10.
Attachment #8503212 - Flags: review?(smichaud)
Comment on attachment 8503212 [details] [diff] [review]
patch

My eyes aren't much good for this kind of thing.  But I'll take your word for it :-)
Attachment #8503212 - Flags: review?(smichaud) → review+
https://hg.mozilla.org/mozilla-central/rev/47ac4791adf3
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Markus, this looks upliftable to me, would you agree? :-)
Flags: needinfo?(mstange)
Comment on attachment 8503212 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: Yosemite visuals
[User impact if declined]: menu and tooltip shadows look off
[Describe test coverage new/current, TBPL]: none
[Risks and why]: extremely low, very simple patch
[String/UUID change made/needed]: none
Flags: needinfo?(mstange)
Attachment #8503212 - Flags: approval-mozilla-beta?
Attachment #8503212 - Flags: approval-mozilla-aurora?
Comment on attachment 8503212 [details] [diff] [review]
patch

Beta+
Aurora+
Attachment #8503212 - Flags: approval-mozilla-beta?
Attachment #8503212 - Flags: approval-mozilla-beta+
Attachment #8503212 - Flags: approval-mozilla-aurora?
Attachment #8503212 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.