Move URLs out of loop.en-us.properties and into the config file

RESOLVED FIXED in Firefox 35

Status

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
mozilla36
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Bug 1078345 added some URLs to the locales file but they should have been part of the Loop config file.
Flags: qe-verify-
Flags: in-testsuite-
Flags: firefox-backlog+
Posted patch Patch (obsolete) — Splinter Review
Attachment #8503350 - Flags: review?(dmose)
Comment on attachment 8503350 [details] [diff] [review]
Patch

Review of attachment 8503350 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/loop/standalone/server.js
@@ +23,5 @@
>      "loop.config.feedbackProductName = '" + feedbackProductName + "';",
>      // XXX Update with the real marketplace url once the FxOS Loop app is
>      //     uploaded to the marketplace bug 1053424
>      "loop.config.marketplaceUrl = 'http://fake-market.herokuapp.com/iframe-install.html'",
> +    "loop.config.brandWebsiteUrl = 'https://www.mozilla.org/firefox/';",

These need to be added to the Makefile as well for make config. Unfortunately we've got them in two locations at the moment, and we've got a bug on file to fix that at some stage later.
Attachment #8503350 - Flags: review?(dmose) → review-
Iteration: 35.3 → 36.1
Posted patch Patch v2Splinter Review
Attachment #8503350 - Attachment is obsolete: true
Attachment #8508949 - Flags: review?(nperriault)
Comment on attachment 8508949 [details] [diff] [review]
Patch v2

Review of attachment 8508949 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. This looks good, r=me with nits addressed.

::: browser/components/loop/standalone/content/js/webapp.jsx
@@ +36,5 @@
>    var UnsupportedBrowserView = React.createClass({
>      render: function() {
>        var useLatestFF = mozL10n.get("use_latest_firefox", {
>          "firefoxBrandNameLink": React.renderComponentToStaticMarkup(
> +          <a target="_blank" href={loop.config.brandWebsiteUrl}>{mozL10n.get("brandShortname")}</a>

Nit:

<a target="_blank" href={loop.config.brandWebsiteUrl}>
  {mozL10n.get("brandShortname")}
</a>

is a bit more readable.

@@ +86,1 @@
>                {mozL10n.get("get_firefox_button", {brandShortname: mozL10n.get("brandShortname")})}

Nit:

{mozL10n.get("get_firefox_button", {
  brandShortname: mozL10n.get("brandShortname")
})}

would be a bit more readable.
Attachment #8508949 - Flags: review?(nperriault) → review+

Updated

5 years ago
backlog: --- → Fx35+
https://hg.mozilla.org/mozilla-central/rev/570579f42954
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in fx-team]
Target Milestone: --- → mozilla36
Comment on attachment 8508949 [details] [diff] [review]
Patch v2

Approval Request Comment
Landed on aurora per IRC with lsblakk with a=loop-only
Attachment #8508949 - Flags: approval-mozilla-aurora?
Attachment #8508949 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.