Closed Bug 1081210 Opened 10 years ago Closed 10 years ago

No way to end call while dialing

Categories

(Firefox OS Graveyard :: Gaia::Loop, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Loop
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: pdol, Assigned: borjasalguero)

References

Details

(Whiteboard: [caf priority: p2][CR 740545][mobile app][blocking][tef-triage][loop in 1.1][loop approved for 1.1])

Attachments

(2 files)

Pull Request
61 bytes, text/x-github-pull-request
jaoo
: review+
Details | Review
Patch to v1.1
61 bytes, text/x-github-pull-request
Details | Review 
Version: 2.0.0.0-prerelease
Build ID: 20141010000201

STR:
- Launch Hello
- Select a Contact to dial
- During Dialing observe lack of way to end call

Expected Results:
I should be able to end the call (could be an accidental dial) while in the dialing sequence.

Observed Results:
There is no way to end the call while in the dialing sequence.
Blocks: 1036490
Assignee: nobody → borja.bugzilla
Hi Peter! Good to have feedback from more people, this is great in order to improve the product!

In this case this was added in order to ensure that the protocol is working in both sides. When calling B from A, we create a WebSocket communication to handle the status of the call (including the hang up action). If A end the call before reaching B, there are some scenarios where B receives the call even if A "ended" it, because the protocol was not established in both sides in that moment.

The good thing is that this is a well-known issue, and actually I was working on it, so it's good to have a bug to track this issue. I'll try upload a patch asap.
Attached file Pull Request — 

    
  

        Attachment #8506216 -
        Flags: review?(josea.olivera)
Severity: normal → critical
Whiteboard: [mobile app][blocking][tef-triage]

    
    

    
  
Comment on attachment 8506216 [details] [review]
Pull Request

LGTM. r=me

Great work here Borja. Thanks!

        Attachment #8506216 -
        Flags: review?(josea.olivera) → review+
Whiteboard: [mobile app][blocking][tef-triage] → [CR 740545][mobile app][blocking][tef-triage]
Whiteboard: [CR 740545][mobile app][blocking][tef-triage] → [caf priority: p2][CR 740545][mobile app][blocking][tef-triage]

    
  
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [caf priority: p2][CR 740545][mobile app][blocking][tef-triage] → [caf priority: p2][CR 740545][mobile app][blocking][tef-triage][loop not in 1.1]

    
    

    
  
Borja, can you uplift it to v1.1 branch?
Flags: needinfo?(borja.bugzilla)
Whiteboard: [caf priority: p2][CR 740545][mobile app][blocking][tef-triage][loop not in 1.1] → [caf priority: p2][CR 740545][mobile app][blocking][tef-triage][loop not in 1.1][loop approved for 1.1]

    
    

    
  

      
      
      
      

        Attached file
          
        Patch to v1.1
        — 
      

    


  
Let's double check everything is fine before merging. The patch is the same code as is in master!
Flags: needinfo?(borja.bugzilla)

        Attachment #8508329 -
        Flags: review?(josea.olivera)

    
  

        Attachment #8508329 -
        Flags: review?(josea.olivera)

    
    

    
  
As the code is the same, M. Angeles could you try just to verify everything is working as expected? Thanks!
Flags: needinfo?(oteo)

    
    

    
  
(In reply to Borja Salguero [:borjasalguero] from comment #7)
> As the code is the same, M. Angeles could you try just to verify everything
> is working as expected? Thanks!

I already tested in master last Friday, and really busy today, so let's land it in 1.1 branch
Thanks a lot Borja!!
Flags: needinfo?(oteo)
Whiteboard: [caf priority: p2][CR 740545][mobile app][blocking][tef-triage][loop not in 1.1][loop approved for 1.1] → [caf priority: p2][CR 740545][mobile app][blocking][tef-triage][loop in 1.1][loop approved for 1.1]

    
    

    
  
Verified on:
Flame: user.v2.0.184based.B-57.Gecko-dde9d61.Gaia-7b8df99
FireE: firee-kk-v2.0-SW2E5-4
Loop 1.1, version: aba155c
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: