Closed
Bug 1081276
Opened 10 years ago
Closed 10 years ago
Don't use Java assertions
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: ckitching, Assigned: ckitching)
Details
Attachments
(1 file, 2 obsolete files)
1.62 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
Java assertions should not be used on Android. We have our own Assert class which (... hopefully...) gets stripped by Proguard in release builds. Let's fix this.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8503358 -
Flags: review?(rnewman)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → chriskitching
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8503358 -
Flags: review?(rnewman) → review+
Updated•10 years ago
|
OS: Linux → Android
Hardware: x86_64 → All
Assignee | ||
Comment 2•10 years ago
|
||
... bloody third party code...
Attachment #8503477 -
Flags: review?(rnewman)
Assignee | ||
Updated•10 years ago
|
Attachment #8503358 -
Attachment is obsolete: true
Updated•10 years ago
|
Attachment #8503477 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8503619 -
Flags: review?(rnewman)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8503619 [details] [diff] [review] Don't notify() without holding the monitor Whoops!
Attachment #8503619 -
Attachment is obsolete: true
Attachment #8503619 -
Flags: review?(rnewman)
Assignee | ||
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1ef3c935199a
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1ef3c935199a
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
(In reply to Chris Kitching [:ckitching] from comment #0) > Java assertions should not be used on Android. To elaborate: 1) it looks like they can't be turned on easily because you don't control the JVM: http://softwarecave.org/2014/01/14/assertions-on-android/ 2) Even if you could use them, the assertions stay in the class files and can bloat the release code: https://docs.oracle.com/javase/7/docs/technotes/guides/language/assert.html#usage-adv-removing
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•