Closed
Bug 1081281
Opened 10 years ago
Closed 10 years ago
Unnecessary double-boxing in ContactService
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 35
People
(Reporter: ckitching, Assigned: ckitching)
Details
Attachments
(1 file)
3.79 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
The ContactService boxes a boxed Integer. *sigh* I suspect these ints really want replacing with an enum, but here's a microoptimisation. I get the feeling someone will be taking a machete to ContactService at some point, so am slightly loathe to refactor it too much.
Assignee | ||
Updated•10 years ago
|
Assignee: chriskitching → nobody
Assignee | ||
Comment 1•10 years ago
|
||
Patch pointing out the madness...
Attachment #8503365 -
Flags: feedback?(rnewman)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → chriskitching
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8503365 -
Flags: feedback?(rnewman) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/611ffa760b44
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/611ffa760b44
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•