Closed Bug 1081281 Opened 6 years ago Closed 6 years ago

Unnecessary double-boxing in ContactService

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: ckitching, Assigned: ckitching)

Details

Attachments

(1 file)

The ContactService boxes a boxed Integer.

*sigh*

I suspect these ints really want replacing with an enum, but here's a microoptimisation. I get the feeling someone will be taking a machete to ContactService at some point, so am slightly loathe to refactor it too much.
Assignee: chriskitching → nobody
Patch pointing out the madness...
Attachment #8503365 - Flags: feedback?(rnewman)
Assignee: nobody → chriskitching
Status: NEW → ASSIGNED
Attachment #8503365 - Flags: feedback?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/611ffa760b44
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.