Use the correct calling convention on InitDwriteBG

RESOLVED FIXED in mozilla35

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

(Blocks 1 bug)

unspecified
mozilla35
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Otherwise our stack is misaligned by the time we return from this.
This misalignment doesn't cause a crash with the Winodws thread
startup code, but it does with ASAN because it does many things
after the thread entry point exits.
This bug could have been avoided if we did not use a C-style cast to stop the compiler from yelling at us for having the wrong calling convention. :)
Assignee: nobody → ehsan.akhgari
Attachment #8503366 - Flags: review?(jmuizelaar)
Blocks: winasan
Attachment #8503366 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/4ef90fdc2c58
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.