1081297 - Disable UnifiedComplete for Firefox 35

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Marco Bonardo [:mak]]

We will delay the feature to 36.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Aurora was merged yesterday. Think we can land a patch pref'ing it off on Aurora now.

Comment 2

[Marco Bonardo [:mak]]

yep, I must push to try first, to be sure tests won't break. We started relying a bit more on the feature enabled and lots of code landed, so better stay safe.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Sure, sgtm.

Comment 4

[Marco Bonardo [:mak]]

browser_bug1024133-switchtab-override-keynav.js is broken and will need a fix.

18:05:54     INFO -  67 INFO TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug1024133-switchtab-override-keynav.js | The autocomplete popup is correctly open
18:05:54     INFO -  68 INFO Select second autocomplete popup entry
18:05:54     INFO -  69 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug1024133-switchtab-override-keynav.js | switch to tab entry found -
18:05:54     INFO -  Stack trace:
18:05:54     INFO -      chrome://mochitests/content/browser/browser/base/content/test/general/browser_bug1024133-switchtab-override-keynav.js:test_switchtab_override_keynav:44
18:05:54     INFO -      Tester_execTest@chrome://mochikit/content/browser-test.js:642:9
18:05:54     INFO -      Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:568:7

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8506377 [details] [diff] [review]
patch v1

Approval Request Comment
[Feature/regressing bug #]: UnifiedCompletr
[User impact if declined]: The feature is not ready to be released
[Describe test coverage new/current, TBPL]:
[Risks and why]: low risk, disabling incomplete feature
[String/UUID change made/needed]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0f206c761e1c

Comment 8

[Andrei Vaida [:avaida]]

Confirmed that the 'browser.urlbar.unifiedcomplete' pref is set to 'false' on Aurora 35.0a2 (2014-10-22), using Windows 7 64-bit, Mac OS X 10.9.5 and Ubuntu 13.10 64-bit. Smoke testing found NO new issues across platforms.