1081346 - Status Bar is white on white after adding bookmark to the homescreen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Gregor Wagner [:gwagner]]

Attachment: statusbar

On 2.1:

STR:
Open page in browser
Add to homescreen

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

I'll take a look.

Comment 3

[Gregor Wagner [:gwagner]]

[Blocking Requested - why for this release]:
Bad UX

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Caused by bug 1074043. Probably just need to make sure we set the icon color when closing activities too.

Comment 5

[Aus Lacroix [:aus]]

(In reply to Michael Henretty [:mhenretty] from comment #4)
> Caused by bug 1074043. Probably just need to make sure we set the icon color
> when closing activities too.

Yep! I can whip up a patch for this easily.

Comment 6

[Gregor Wagner [:gwagner]]

Bad UX

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Assigning over to :aus since he knows this code way better than I.

Comment 8

[Aus Lacroix [:aus]]

Attachment: Pull Request - Update status bar appearance on activity termination.

A small detail forgotten when I fixed part of this issue before... What happens to the icons when the activity terminates and returns to an application with a completely different theme? *sigh*

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

FWIW, this fixes the issue for me. Just heads up, the statusbar_test.js unit test will have to be fixed before landing.

Thanks for fixing this so fast!

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8503511 [details] [review]
Pull Request - Update status bar appearance on activity termination.

This fix is valid, but my question: why the activityclosed handler does not set the appearance well? I need to know what's wrong with it.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #10)
> Comment on attachment 8503511 [details] [review]
> Pull Request - Update status bar appearance on activity termination.
> 
> This fix is valid, but my question: why the activityclosed handler does not
> set the appearance well? I need to know what's wrong with it.

Hmm..looks like we never use activityclosed event. And even with this event we could not use it to change the appearance..
We should have/use appforeground event in the future if we are getting rid of the setVisible struggle.

Aus, please add unit test for your patch and ask review again, thanks.

Comment 12

[Aus Lacroix [:aus]]

Comment on attachment 8503511 [details] [review]
Pull Request - Update status bar appearance on activity termination.

I added a new test to ensure this functionality doesn't regress. The logic is a little complex so I also added some comments to avoid confusion later.

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8503511 [details] [review]
Pull Request - Update status bar appearance on activity termination.

r=me

Comment 14

[Aus Lacroix [:aus]]

Commit (master): https://github.com/mozilla-b2g/gaia/commit/ec355e1c02ebffbfda778661c2501a0bc78317dc

Fixed!

Comment 15

[Aus Lacroix [:aus]]

Comment on attachment 8503511 [details] [review]
Pull Request - Update status bar appearance on activity termination.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): New feature (new status bar with color theming)
[User impact] if declined: Icons become unreadable until user returns to homescreen or opens another application.
[Testing completed]: On device (Flame 319M v184), robust unit-tests
[Risk to taking this patch] (and alternatives if risky): Low. Tests cover regression potential.
[String changes made]: None.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/2cc7ad62babbc8cc78b892cb1173b67b55d91286

Comment 17

[Duane Dixon [:ddixon]]

Issue is verified fixed in Flame 2.2, 2.1 (Full Flash, nightly). 

Actual Results: Status Bar UI behaves correctly when user saves web page to homescreen. 

Device: Flame Master
Build ID: 20141017040208
Gaia: abef62c0623e5504a97b4fd411e879a67b285b52
Gecko: ae1dfa192faf
Version: 36.0a1 (Master)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Device: Flame 2.1
Build ID: 20141017001201
Gaia: 1ea74943cfe525c76a074ca1d7de8e51a70f6b98
Gecko: 2befa902ff5c
Version: 34.0 (2.1)
Firmware Version: v180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0