Closed Bug 1081375 Opened 6 years ago Closed 6 years ago

Remove write-only datastructures

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 37

People

(Reporter: ckitching, Assigned: ckitching)

Details

(Whiteboard: [upstream needed])

Attachments

(1 file, 1 obsolete file)

In several places we carefully build a collection that we then never read...

This patch variously prunes or uses them for the purpose they were obviously intended...

Maybe some of the pruned ones should be put to use somehow, too?
Attached patch Remove write-only datastructures (obsolete) — Splinter Review
Attachment #8503464 - Flags: review?(rnewman)
I'm particularly concerned about AndroidBrowserRepositoryDataAccessor. That reallocation must've been for *something* at some point...
Attachment #8503466 - Flags: review?(rnewman)
Attachment #8503464 - Attachment is obsolete: true
Attachment #8503464 - Flags: review?(rnewman)
Comment on attachment 8503466 [details] [diff] [review]
Remove write-only datastructures

Review of attachment 8503466 [details] [diff] [review]:
-----------------------------------------------------------------

Uplift needed.
Attachment #8503466 - Flags: review?(rnewman) → review+
Status: NEW → ASSIGNED
Hardware: ARM → All
Whiteboard: [upstream needed]
https://hg.mozilla.org/mozilla-central/rev/0f90bdd80217
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.