Closed
Bug 1081375
Opened 11 years ago
Closed 11 years ago
Remove write-only datastructures
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: ckitching, Assigned: ckitching)
Details
(Whiteboard: [upstream needed])
Attachments
(1 file, 1 obsolete file)
|
4.95 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
In several places we carefully build a collection that we then never read...
This patch variously prunes or uses them for the purpose they were obviously intended...
Maybe some of the pruned ones should be put to use somehow, too?
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8503464 -
Flags: review?(rnewman)
|
|
Assignee | |
Comment 2•11 years ago
|
||
I'm particularly concerned about AndroidBrowserRepositoryDataAccessor. That reallocation must've been for *something* at some point...
Attachment #8503466 -
Flags: review?(rnewman)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8503464 -
Attachment is obsolete: true
Attachment #8503464 -
Flags: review?(rnewman)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8503466 [details] [diff] [review]
Remove write-only datastructures
Review of attachment 8503466 [details] [diff] [review]:
-----------------------------------------------------------------
Uplift needed.
Attachment #8503466 -
Flags: review?(rnewman) → review+
|
|
||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Hardware: ARM → All
Whiteboard: [upstream needed]
|
|
Assignee | |
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•