Closed Bug 1081395 Opened 5 years ago Closed 5 years ago

Don't use tab characters for indentation

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: ckitching, Assigned: ckitching)

Details

Attachments

(1 file)

Like, ever.
Attachment #8503487 - Flags: review?(rnewman)
Comment on attachment 8503487 [details] [diff] [review]
Stop using tabs for indentation

Review of attachment 8503487 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with nits.

::: mobile/android/base/LightweightThemeDrawable.java
@@ +116,1 @@
>          // Clamp mode will repeat the last row of pixels.

You need to fix the indenting throughout this method, too.

::: mobile/android/base/TextSelection.java
@@ +192,5 @@
> +    String itemsString = items.toString();
> +    if (itemsString.equals(mCurrentItems)) {
> +        return;
> +    }
> +    mCurrentItems = itemsString;

Fix indenting.

@@ +213,5 @@
>          if (context instanceof ActionModeCompat.Presenter) {
>              final ActionModeCompat.Presenter presenter = (ActionModeCompat.Presenter) context;
>              presenter.endActionModeCompat();
>          }
> +    mCurrentItems = null;

Same.

::: mobile/android/base/background/preferences/PreferenceManagerCompat.java
@@ +67,4 @@
>       * Sets the owning preference fragment
>       */
>      static void setFragment(PreferenceManager manager, PreferenceFragment fragment) {
> +    // stub

Same.

::: mobile/android/base/prompts/ColorPickerInput.java
@@ +53,5 @@
>      }
>  
>      @Override
>      public boolean canApplyInputStyle() {
> +    return false;

Same.

::: mobile/android/base/tests/helpers/AssertionHelper.java
@@ +103,4 @@
>      }
>  
>      public static void fAssertIsNotPixel(final String message, final int actual, final int r, final int g, final int b) {
> +    sAsserter.isnotpixel(actual, r, g, b, message);

Same.

::: mobile/android/base/updater/UpdateService.java
@@ +400,1 @@
>              .setDeleteIntent(deleteIntent);

Column-align on dots while you're here.

@@ +480,5 @@
>              while ((len = input.read(buf, 0, BUFSIZE)) > 0 && !mCancelDownload) {
>                  output.write(buf, 0, len);
>                  bytesRead += len;
>                  // Updating the notification takes time so only do it every 1MB
>                  if(bytesRead - lastNotify > 1048576) {

Space before paren.

::: mobile/android/base/widget/TabThumbnailWrapper.java
@@ +27,5 @@
>          final int[] drawableState = super.onCreateDrawableState(extraSpace + 1);
>  
>          if (mRecording) {
>              mergeDrawableStates(drawableState, STATE_RECORDING);
> +    }

Fix indenting.
Attachment #8503487 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/mozilla-central/rev/67c1e949e474
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
(Extra push to deal with the incorrect assumption that four-space intentation is used on all our Java code, instead of merely most of it)
You need to log in before you can comment on or make changes to this bug.