If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Declare lots of effectively-final fields as final.

RESOLVED FIXED in Firefox 35

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ckitching, Assigned: ckitching)

Tracking

unspecified
Firefox 35
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Because why not?
(Assignee)

Comment 1

3 years ago
Created attachment 8503489 [details] [diff] [review]
Finalise large numbers of fields
Attachment #8503489 - Flags: review?(rnewman)
Comment on attachment 8503489 [details] [diff] [review]
Finalise large numbers of fields

Review of attachment 8503489 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me.

Don't forget to upstream.

If this lands before 35 merges, I'll be happy -- makes it easier to uplift patches from 36.

::: mobile/android/base/gfx/Axis.java
@@ +129,5 @@
>      private float mFirstTouchPos;           /* Position of the first touch event on the current drag. */
>      private float mTouchPos;                /* Position of the most recent touch event on the current drag. */
>      private float mLastTouchPos;            /* Position of the touch event before touchPos. */
>      private float mVelocity;                /* Velocity in this direction; pixels per animation frame. */
> +    private final float[] mRecentVelocities;      /* Circular buffer of recent velocities since last touch start. */

Cursed alignment.

::: mobile/android/base/preferences/AndroidImport.java
@@ +21,5 @@
>  
>  import java.util.ArrayList;
>  
>  class AndroidImport implements Runnable {
>      static final private String LOGTAG = "AndroidImport";

Change this to private static final.

::: mobile/android/base/preferences/AndroidImportPreference.java
@@ +15,5 @@
>  import android.util.AttributeSet;
>  import android.util.Log;
>  
>  class AndroidImportPreference extends MultiPrefMultiChoicePreference {
>      static final private String LOGTAG = "AndroidImport";

Same.

::: mobile/android/base/sync/jpake/JPakeClient.java
@@ +37,5 @@
>  import ch.boye.httpclientandroidlib.entity.StringEntity;
>  
>  public class JPakeClient {
>  
> +  private static final String       LOG_TAG                 = "JPakeClient";

Eliminate the block indenting here.
Attachment #8503489 - Flags: review?(rnewman) → review+
(Assignee)

Comment 3

3 years ago
Created attachment 8503525 [details] [diff] [review]
Finalise large numbers of fields

What, *all* of the block indenting? Well, okay. It's certainly nicer if we get rid of it.
(Assignee)

Updated

3 years ago
Attachment #8503489 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/e925a610e68d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Upstreamed.
You need to log in before you can comment on or make changes to this bug.