1081404 - [Skia] Possible leak in |SkPictureRecorder::endRecording|

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[Eric Rahm [:erahm]]

In |SkPictureRecorder::endRecording| [1] |picture| can be assigned to once [2], and then assigned to again [3] thus leaking the original allocation.

[1] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/gfx/skia/trunk/src/core/SkPictureRecorder.cpp#l58
[2] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/gfx/skia/trunk/src/core/SkPictureRecorder.cpp#l62
[3] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/gfx/skia/trunk/src/core/SkPictureRecorder.cpp#l68

Comment 1

[Jeff Muizelaar [:jrmuizel]]

It might be more worth while to report this upstream.

Comment 2

[Eric Rahm [:erahm]]

I can do that, but it's not clear to me what the official upstream skia repo is for us. Is it just https://github.com/google/skia ?

Comment 3

[Eric Rahm [:erahm]]

FWIW this seems to have been fixed in the google version recently: https://github.com/google/skia/commit/8e12656096fceeed8b3cc4284d57dea04893b455

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Upstream is https://code.google.com/p/skia/ and https://skia.googlesource.com/skia

We'll get this fix next time we update skia.

Comment 5

[Nicholas Nethercote [inactive]]

Sounds like we'll pick this up eventually without doing anything special.