[Skia] Possible leak in |SkPictureRecorder::endRecording|

RESOLVED WONTFIX

Status

()

Core
Graphics
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: erahm, Unassigned)

Tracking

({coverity})

Trunk
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [MemShrink:P3][CID 1244812])

In |SkPictureRecorder::endRecording| [1] |picture| can be assigned to once [2], and then assigned to again [3] thus leaking the original allocation.

[1] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/gfx/skia/trunk/src/core/SkPictureRecorder.cpp#l58
[2] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/gfx/skia/trunk/src/core/SkPictureRecorder.cpp#l62
[3] http://hg.mozilla.org/mozilla-central/annotate/e4cfacb76830/gfx/skia/trunk/src/core/SkPictureRecorder.cpp#l68
It might be more worth while to report this upstream.
I can do that, but it's not clear to me what the official upstream skia repo is for us. Is it just https://github.com/google/skia ?
Flags: needinfo?(jmuizelaar)
FWIW this seems to have been fixed in the google version recently: https://github.com/google/skia/commit/8e12656096fceeed8b3cc4284d57dea04893b455
Upstream is https://code.google.com/p/skia/ and https://skia.googlesource.com/skia

We'll get this fix next time we update skia.
Flags: needinfo?(jmuizelaar)
Sounds like we'll pick this up eventually without doing anything special.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Whiteboard: [MemShrink][CID 1244812] → [MemShrink:P3][CID 1244812]
You need to log in before you can comment on or make changes to this bug.