Closed Bug 1081406 Opened 6 years ago Closed 6 years ago

Remove unnecessary numeric casts

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 35

People

(Reporter: ckitching, Assigned: ckitching)

Details

Attachments

(1 file)

No need to have all this needless code lying around...
Attachment #8503500 - Flags: review?(rnewman)
Comment on attachment 8503500 [details] [diff] [review]
Remove unnecessary numeric casts

Review of attachment 8503500 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me IFF these are all automatically generated based on the language spec. Upstream needed.
Attachment #8503500 - Flags: review?(rnewman) → review+
Status: NEW → ASSIGNED
Component: Overlays → General
Hardware: ARM → All
Whiteboard: [upstream needed]
(In reply to Richard Newman [:rnewman] from comment #2)
> Comment on attachment 8503500 [details] [diff] [review]
> Remove unnecessary numeric casts
> 
> Review of attachment 8503500 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> rs=me IFF these are all automatically generated based on the language spec.
> Upstream needed.

They are. Nick's Gradle integration made a bunch of IDEA's features work that didn't work with my manual config. I'm therefore going on a rampage automatically (or partially automatically) fixing the problems it finds.

See a try run of all of these patches here:
https://tbpl.mozilla.org/?tree=Try&rev=e32f0510f2fc

The world didn't end!
https://hg.mozilla.org/mozilla-central/rev/2878bf6cbc1f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
Upstreamed.
Whiteboard: [upstream needed]
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.