1081426 - Create ScreenBrightnessTransition module and tests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Move transitionBrightness() out of ScreenManager before working on improvements like better transition and dismantle ScreenManager. It is too big to take anything more complex.

Comment 1

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#25048

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8503535 [details] [review]
mozilla-b2g:master PR#25048

Alive, are you the best person to review this? We should also go through the naming of the file and the function if that doesn't fit into your convention.

Thanks!

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8503535 [details] [review]
mozilla-b2g:master PR#25048

Left some ideas in github comments to simplify the parent module, lemme know if you disagree it's a better pattern.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I ended up changing the name of the file that contains ScreenBrightnessTransition. Let's figure out how to move out all screen brightness logic (and the naming of the file / module) later.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/9500e9b6a365553f49f1924a9b763506aa7245ea

30 lines away from ScreenManager :)

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=7d8a121abf9f