Create ScreenBrightnessTransition module and tests

RESOLVED FIXED in 2.1 S7 (24Oct)

Status

Firefox OS
Gaia::System
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: timdream, Assigned: timdream)

Tracking

(Blocks: 1 bug)

unspecified
2.1 S7 (24Oct)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [FT:System-Platform])

Attachments

(1 attachment)

Move transitionBrightness() out of ScreenManager before working on improvements like better transition and dismantle ScreenManager. It is too big to take anything more complex.
Created attachment 8503535 [details] [review]
mozilla-b2g:master PR#25048
Whiteboard: [FT:System-Platform]
Comment on attachment 8503535 [details] [review]
mozilla-b2g:master PR#25048

Alive, are you the best person to review this? We should also go through the naming of the file and the function if that doesn't fit into your convention.

Thanks!
Attachment #8503535 - Flags: review?(alive)
Comment on attachment 8503535 [details] [review]
mozilla-b2g:master PR#25048

Left some ideas in github comments to simplify the parent module, lemme know if you disagree it's a better pattern.
Attachment #8503535 - Flags: review?(alive) → review+
I ended up changing the name of the file that contains ScreenBrightnessTransition. Let's figure out how to move out all screen brightness logic (and the naming of the file / module) later.
Target Milestone: --- → 2.1 S7 (24Oct)
master: https://github.com/mozilla-b2g/gaia/commit/9500e9b6a365553f49f1924a9b763506aa7245ea

30 lines away from ScreenManager :)

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=7d8a121abf9f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.