Closed
Bug 1081461
Opened 10 years ago
Closed 7 years ago
[Dialer] The font size of numbers largen after user enter dialer app .
Categories
(Firefox OS Graveyard :: GonkIntegration, defect, P2)
Firefox OS Graveyard
GonkIntegration
Tracking
(tracking-b2g:+)
RESOLVED
WONTFIX
tracking-b2g | + |
People
(Reporter: sync-1, Assigned: jfkthame)
Details
Attachments
(3 files)
49.98 KB,
application/x-rar-compressed
|
Details | |
8.09 MB,
video/3gpp
|
Details | |
1.35 KB,
patch
|
Details | Diff | Splinter Review |
FFOS V2.0
DEFECT DESCRIPTION:
The font size of numbers largen after user enter dialer app.
REPRODUCING PROCEDURES:
Precondition:Set the system language as Greek.
1. Launch "Dialer" App
2. The font size of numbers largen(KO)
EXPECTED BEHAVIOUR:
The font size of numbers should not largen
ASSOCIATE SPECIFICATION:
TEST PLAN REFERENCE:
TOOLS AND PLATFORMS USED:
USER IMPACT:
REPRODUCING RATE:
100%
For FT PR, Please list reference mobile's behavior:
Comment 2•10 years ago
|
||
Could you provide us with a screenshot of the issue?
Flags: needinfo?(sync-1)
Comment 3•10 years ago
|
||
Please see the video for this issue, thanks.
Comment 4•10 years ago
|
||
(In reply to Lingling Zhao from comment #3)
> Please see the video for this issue, thanks.
Thanks, this helps a lot.
Flags: needinfo?(sync-1)
Comment 5•10 years ago
|
||
I tested about 6 non-latin LTR languages and Greek is the only one where this issue occurs.
Delphine, is Greek an officially supported locale for 2.0? Do we know what are the locale that don't use the standard font?
Flags: needinfo?(lebedel.delphine)
Comment 6•10 years ago
|
||
Yes, Greek is a supported locale on 2.0.
For fonts, that's not my area of expertise. Ni :jfkthame for possible help about question in comment 5! thanks
Flags: needinfo?(lebedel.delphine) → needinfo?(jfkthame)
Assignee | ||
Comment 7•10 years ago
|
||
If you look at the actual shapes of the digits, you can see that it's not just changing the size, it's changing to a different typeface. It looks to me like it's initially displaying with Fira Sans, but then after a moment the font is changing to Roboto.
Note that the default sans-serif font for Greek is defined as Roboto in modules/libpref/init/all.js, which was done because of problems with the Greek letters in Fira (see bug 928026). I think this could probably be changed now, as we have an updated version of Fira in the repository (see bug 940397).
I'm not sure why the style changes after the dialer app is initially displayed, though; that seems to suggest some style rules may be getting loaded too lazily, resulting in an extra reflow?
Flags: needinfo?(jfkthame)
Assignee | ||
Comment 8•10 years ago
|
||
Patryk, do you agree we should be changing the default Greek fonts? My understanding is that the concerns with Fira's Greek have been addressed.
Attachment #8504305 -
Flags: review?(padamczyk)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Comment 9•10 years ago
|
||
[Blocking Requested - why for this release]: Greek is officially supported and this is a visible problem.
blocking-b2g: --- → 2.0?
Component: Gaia::Dialer → GonkIntegration
Assignee | ||
Comment 10•10 years ago
|
||
(In reply to Doug Sherk (:drs) (use needinfo?) from comment #9)
> [Blocking Requested - why for this release]: Greek is officially supported
> and this is a visible problem.
The visual problem should be fixed if we switch the default Greek font; however, Patryk has reminded me that we don't currently have full support for ancient Greek (all the accented forms, etc) in Fira, only for modern Greek.
So the trade-off is likely to be that any content written in polytonic Greek (probably a small minority of what's online, but still...) will end up falling back to a different font for the letters that are missing in Fira, giving something of a "ransom-note" effect.
Comment 11•10 years ago
|
||
While this is bad from a polish standpoint, at this point in the 2.0 cycle, the triage group didn't feel it was something we'd hold the release for. Bhavana, I'll let you make the final call on blocking or uplift+blocking, etc.
Flags: needinfo?(bbajaj)
Comment 12•10 years ago
|
||
[Blocking Requested - why for this release]:
(In reply to Jonathan Kew (:jfkthame) from comment #10)
> (In reply to Doug Sherk (:drs) (use needinfo?) from comment #9)
> > [Blocking Requested - why for this release]: Greek is officially supported
> > and this is a visible problem.
>
> The visual problem should be fixed if we switch the default Greek font;
> however, Patryk has reminded me that we don't currently have full support
> for ancient Greek (all the accented forms, etc) in Fira, only for modern
> Greek.
>
> So the trade-off is likely to be that any content written in polytonic Greek
> (probably a small minority of what's online, but still...) will end up
> falling back to a different font for the letters that are missing in Fira,
> giving something of a "ransom-note" effect.
I am worried about these fallouts once we switch. I think the polish issue on dialer issue is something we can live and is minor in the short run for 2.0 given where we are close to shipping, but should be fixed in 2.1.
Delphine, will also help get localizer input here.
blocking-b2g: 2.0? → 2.1?
Flags: needinfo?(bbajaj)
Comment 13•10 years ago
|
||
Asking Greek localizer for his input here
Iosif: based on the details of this bug do you agree with the conclusion in comment 12? Or do you think this is worth the risk at this point?
Flags: needinfo?(sirios2222)
Comment 14•10 years ago
|
||
I am almost certain there are no words using the polytonic system in our translations. Personally I don't think it worth holding the release for this issue. I'd like to take Fredy's advice too if there is more time available. If not, I'd suggest we move with the release as scheduled.
Flags: needinfo?(sirios2222)
Comment 15•10 years ago
|
||
Clearing the nom and tracking it so we can resolve this in upcoming release.
:Jonathan, if this needs to land on 2.1, it will have to made an exception for approval(please NI me), so the sooner we can land this it will be better else this will get fixed in 2.2(sometime later next year).
blocking-b2g: 2.1? → ---
tracking-b2g:
--- → +
Comment 16•10 years ago
|
||
(In reply to Iosif Psychas [:TheGallery] from comment #14)
> I am almost certain there are no words using the polytonic system in our
> translations. Personally I don't think it worth holding the release for this
> issue. I'd like to take Fredy's advice too if there is more time available.
> If not, I'd suggest we move with the release as scheduled.
I confirm that we don't use polytonic system in our l10n. The only cases that could possibly use polytonic Greek in Firefox OS are webapps and web pages (through browser app). So, if the font change affects only the l10n strings, I guess there is no problem.
Updated•10 years ago
|
Attachment #8504305 -
Flags: review?(padamczyk)
Comment 17•10 years ago
|
||
Dears,
How about the bug now?
Comment 18•10 years ago
|
||
We should try to get this into 2.2 (was 2.1.1).
Comment 19•10 years ago
|
||
Dears,
I find this bug can not be reproduced in V2.2. Can you please provide the patch? So I can merge it into V2.0 in our side.
Thanks.
Comment 20•7 years ago
|
||
Firefox OS is not being worked on
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•