1081489 - Don't allow our own search to index questions marked as spam

Status: RESOLVED FIXED

(support.mozilla.org :: Search, defect, P1)

Description

[[:philipp]]

at the moment, questions marked as spam are still showing up in search results on SUMO instead of being removed from the search index - for example see this query: https://support.mozilla.org/en-US/search?q=season&num_voted=0&num_votes=&asked_by=&answered_by=&q_tags=&created=0&created_date=&updated=0&updated_date=&sortby=0&a=1&w=2#support

Comment 1

[[:philipp]]

edit: this only happens through the advanced search, so probably it isn't that big of a problem...

Comment 2

[Alice Wyman]

I also get spam results in the AAQ process:

https://support.mozilla.org/en-US/questions/new/desktop/other?search=season#summarize-question

Comment 3

[Alice Wyman]

Attachment: AAQspam.png

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

not good

Comment 5

[Cor vL (cor-el)]

Maybe hide threads marked as spam behind a hidden is_spam parameter that defaults to -1 (no;don't care;yes) when absent and that only works for moderators.
That would still make it possible to search for such threads or the OP that has created them.
Normal visitors shouldn't be able to find such threads.

See also:
https://support.mozilla.org/en-US/forums/contributors/710806?page=2

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

I'll take a look. Moving into current sprint.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/2213

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/ffc7c1e1088364b4375012a4c65de12f034e2866

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod.

Comment 10

[Alice Wyman]

(In reply to Cor vL (cor-el) from comment #5)
> Maybe hide threads marked as spam behind a hidden is_spam parameter that
> defaults to -1 (no;don't care;yes) when absent and that only works for
> moderators.
> That would still make it possible to search for such threads or the OP that
> has created them.
> Normal visitors shouldn't be able to find such threads.
> 

(Cor-el? Ricky?) Could you file a new bug on allowing moderators to find threads marked as spam?  

Moderators used to be able to review the "questions" of a deactivated user from the link to the user's profile, either in forum threads or in  https://support.mozilla.org/en-US/users/deactivation_log 

This is no longer possible (the search results are empty) if the question has been marked as spam. You also can't find any results with Advanced Search, either by searching on the username or the thread content. 

Here's a moderators forum thread containing some examples of deactivated users and thread links, if anyone wants to test this:
https://support.mozilla.org/en-US/forums/forum-moderators/710832