Closed
Bug 1081582
Opened 10 years ago
Closed 10 years ago
Fix various typos
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: ckitching, Assigned: ckitching)
Details
Attachments
(2 files)
99.01 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
95.38 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
Bad spelling is annoying.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8503693 -
Flags: review?(rnewman)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8503694 -
Flags: review?(rnewman)
Comment 3•10 years ago
|
||
Comment on attachment 8503693 [details] [diff] [review] Fix spelling Review of attachment 8503693 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/base/ContactService.java @@ +119,5 @@ > > @Override > public void handleMessage(final String event, final JSONObject message) { > // If the account chooser dialog needs shown to the user, the message handling becomes > + // asynchronous so it needs posted to a background thread from the UI thread when the needs to be posted @@ +1962,5 @@ > mEmailTypesMap.put("mobile", Email.TYPE_MOBILE); > mEmailTypesMap.put("work", Email.TYPE_WORK); > } > > + private int getWebsiteType(String websiteType) { Oh jesus ContactService. ::: mobile/android/base/EditBookmarkDialog.java @@ +53,5 @@ > } > > /** > * This text watcher to enable or disable the OK button if the dialog contains > + * valid information. This class is overridden to do data checking different fields. on different ::: mobile/android/base/GeckoView.java @@ +579,3 @@ > */ > public void onPageStop(GeckoView view, GeckoView.Browser browser, boolean success); > Fix trailing whitespace, too. ::: mobile/android/base/gfx/GLController.java @@ +183,5 @@ > } > > // Only try to create the compositor if we have a valid surface and gecko is up. When these > // two conditions are satisfied, we can be relatively sure that the compositor creation will > + // happen without needing to block anywhere. Do it with a sync gecko event so that the also s/sync/synchronous, s/gecko/Gecko @@ +188,1 @@ > // android doesn't have a chance to destroy our surface in between. s/android/Android ::: mobile/android/base/home/TwoLinePageRow.java @@ +250,5 @@ > // Blank the Favicon, so we don't show the wrong Favicon if we scroll and miss DB. > mFavicon.clearImage(); > Favicons.cancelFaviconLoad(mLoadFaviconJobId); > > + // Displayed RecentTabsPanel urls may refer to pages opened in readermode, so we s/readermode/reader mode, s/urls/URLs/ ::: mobile/android/base/prompts/Prompt.java @@ +375,5 @@ > /* Add the requested input elements to the dialog. > * > * @param builder > * the alert builder currently building this dialog. > * @return Trailing whitespace. @@ +377,5 @@ > * @param builder > * the alert builder currently building this dialog. > * @return > * return true if the inputs were added successfully. This may fail > + * if the requested input is compatible with this Android version Closing full stop. ::: mobile/android/base/toolbar/ToolbarDisplayLayout.java @@ -579,5 @@ > } > > void prepareStopEditingAnimation(PropertyAnimator anim) { > // Fade toolbar buttons (page actions, stop) after the entry > - // is schrunk back to its original size. schrunk is so awesome, though. ::: mobile/android/base/widget/ActivityChooserModel.java @@ +203,5 @@ > /** > * The default name of the choice history file. > */ > public static final String DEFAULT_HISTORY_FILE_NAME = > + "activity_chooser_model_history.xml"; This isn't even used. Delete it, and the comment that refers to it.
Attachment #8503693 -
Flags: review?(rnewman) → review+
Comment 4•10 years ago
|
||
Comment on attachment 8503694 [details] [diff] [review] Fix spelling Review of attachment 8503694 [details] [diff] [review]: ----------------------------------------------------------------- See comments on previous upload. ::: mobile/android/base/home/HistoryPanel.java @@ +26,5 @@ > import android.content.Context; > import android.content.DialogInterface; > import android.database.Cursor; > import android.os.Bundle; > +import android.app.LoaderManager.LoaderCallbacks; Easy tiger. Don't touch these.
Attachment #8503694 -
Flags: review?(rnewman) → review+
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Richard Newman [:rnewman] from comment #4) > ::: mobile/android/base/home/HistoryPanel.java > @@ +26,5 @@ > > import android.content.Context; > > import android.content.DialogInterface; > > import android.database.Cursor; > > import android.os.Bundle; > > +import android.app.LoaderManager.LoaderCallbacks; > > Easy tiger. Don't touch these. Bit of IDE misconfiguration there. :/ This is what happens if you don't add the support library. Feck. (In reply to Richard Newman [:rnewman] from comment #3) > ::: mobile/android/base/ContactService.java > @@ +119,5 @@ > > > > @Override > > public void handleMessage(final String event, final JSONObject message) { > > // If the account chooser dialog needs shown to the user, the message handling becomes > > + // asynchronous so it needs posted to a background thread from the UI thread when the > > needs to be posted > > @@ +1962,5 @@ > > mEmailTypesMap.put("mobile", Email.TYPE_MOBILE); > > mEmailTypesMap.put("work", Email.TYPE_WORK); > > } > > > > + private int getWebsiteType(String websiteType) { > > Oh jesus ContactService. There is a certain pattern emerging throughout these cleanup patches, that's for sure. Looking at it, it seems like it might be best just to throw it away entirely and start again. Running the inspection suite on ContactList.java by itself yields 445 warnings: About 0.7% of the total for the project. That is kinda high. :P > ::: mobile/android/base/toolbar/ToolbarDisplayLayout.java > @@ -579,5 @@ > > } > > > > void prepareStopEditingAnimation(PropertyAnimator anim) { > > // Fade toolbar buttons (page actions, stop) after the entry > > - // is schrunk back to its original size. > > schrunk is so awesome, though. I'm just going to assume the person writing it was German, which would make this a pretty understandable typo.
Assignee | ||
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/1f9b1f477588
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1f9b1f477588
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•