Closed
Bug 1081590
Opened 10 years ago
Closed 10 years ago
ConfigurationMigrator downgrading does not work
Categories
(Firefox for Android Graveyard :: Android Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 36
People
(Reporter: ckitching, Assigned: ckitching)
Details
Attachments
(1 file)
1.57 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
While trawling the results of IDEA's inspection suite, I came across this little gem: At: http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/sync/config/ConfigurationMigrator.java#369 if (currentVersion == 0 && desiredVersion == 1) { Logger.info(LOG_TAG, "Upgrading from version 0 to version 1."); upgrade0to1(context, accountManager, account, product, username, serverURL, profile); } else if (currentVersion == 1 && desiredVersion == 0) { Logger.info(LOG_TAG, "Upgrading from version 0 to version 1."); upgrade0to1(context, accountManager, account, product, username, serverURL, profile); } The if branches are identical (which is what the tool picked up on). Whoops! We further see that the suspiciously-useful-looking downgrade1to0 is never called.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8503699 -
Flags: review?(rnewman)
Comment 2•10 years ago
|
||
Comment on attachment 8503699 [details] [diff] [review] Actually call the downgrade function in ConfigurationMigrator Review of attachment 8503699 [details] [diff] [review]: ----------------------------------------------------------------- Upstream needed! ::: mobile/android/base/sync/config/ConfigurationMigrator.java @@ +369,5 @@ > if (currentVersion == 0 && desiredVersion == 1) { > Logger.info(LOG_TAG, "Upgrading from version 0 to version 1."); > upgrade0to1(context, accountManager, account, product, username, serverURL, profile); > } else if (currentVersion == 1 && desiredVersion == 0) { > Logger.info(LOG_TAG, "Upgrading from version 0 to version 1."); Fix the comment, too.
Attachment #8503699 -
Flags: review?(rnewman) → review+
Updated•10 years ago
|
Status: NEW → ASSIGNED
OS: Linux → Android
Hardware: x86_64 → All
Summary: ConfigurationMigrator downgrading does not work. → ConfigurationMigrator downgrading does not work
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a615a67cce1e
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a615a67cce1e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Updated•7 years ago
|
Product: Android Background Services → Firefox for Android
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•