1081631 - docker-worker: Cache volume stat name invalid (according to statsd)

Status: RESOLVED FIXED

(Taskcluster :: Workers, defect)

Description

[James Lal [:lightsofapollo]]

Example: 

docker-worker.aws-provisioner.us-west-2c.gaia.r3-xlarge.cache.volume.resources::7be8a3b8-061a-4746-a17e-e85b66beecf3.hit:1|c

Pretty the '::' makes statsd angry I am not seeing the stats reporting but I am seeing the stats in the log.

Comment 1

[Greg Arndt [:garndt]]

We could change this to be a period and then it would probably align more with how the graphite metrics names are.

Would be something like cache.volume.<cache name>.<instance>.hit make more sense?  If so, I can have a change up real quick.

Comment 2

[Greg Arndt [:garndt]]

It's also possible to just keep the delimiter the same but make the metric name more sane to make statsd/Graphite happy.

Comment 3

[James Lal [:lightsofapollo]]

Now that I have thought about it for stats simply stripping the delimiter and instance is probably better. I personally only care about overall hits/misses for a particular cache name.

Comment 4

[Greg Arndt [:garndt]]

Attachment: github PR: # 53

Stats will now be:
cache.volume.<cache name>.created
cache.volume.<cache name>.miss
cache.volume.<cache name>.hit
cache.volume.<cache name>.<instance id>.removed <---happens when the GC needs to free up space and only unmounted instances are removed

Comment 5

[James Lal [:lightsofapollo]]

Comment on attachment 8504176 [details] [review]
github PR: # 53

r+ with the removal name change we talked about on IRC

Comment 6

[Greg Arndt [:garndt]]

Merged:
https://github.com/taskcluster/docker-worker/commit/04040ec37b16bfb9f3daebd71e3a493913a2175a