108164 - small window extra border bug

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Gabriel Bouvigne]

Load http://www.mp3-tech.org. Then look at the upper right corner, near "what's
new". With 0.9.5 there is an extra window border  inside the rendering window.
This occurs on win2k sp1, and didn't occured with 0.9.4.

Comment 1

[Stefan Seifert]

In the source of http://www.mp3-tech.org/mainpage.html you can see that there
are two encapsulated framesets where the outer has border="false" and the like
but the inner has not. I think the border comes from the second frameset.

According to HTML standards you should have a frameborder="0" and the like on
the frames themselves.

Comment 2

[Boris Zbarsky [:bzbarsky]]

No, descendants should get the frame width and existence from ancestors.  This
inheritance was broken when code was moved from Reflow() to Init()

I've got a fix that's 90% right.  I'll attach a patch as soon as I finish
ironing out the last 10%.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch v.1

Comment 4

[Boris Zbarsky [:bzbarsky]]

hyatt, would you review?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch v.2 (comments from timeless)

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: same but add a missing ")" so it builds. :)

Comment 7

[Marc Attinasi]

Comment on attachment 56565 [details] [diff] [review]
same but add a missing ")" so it builds.  :)

sr=attinasi

Comment 8

[timeless]

Comment on attachment 56565 [details] [diff] [review]
same but add a missing ")" so it builds.  :)

whoops, yeah i see it.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Checked in.