small window extra border bug

RESOLVED FIXED in mozilla0.9.6

Status

()

Core
Layout
P1
normal
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: Gabriel Bouvigne, Assigned: bz)

Tracking

({regression})

Trunk
mozilla0.9.6
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

17 years ago
Load http://www.mp3-tech.org. Then look at the upper right corner, near "what's
new". With 0.9.5 there is an extra window border  inside the rendering window.
This occurs on win2k sp1, and didn't occured with 0.9.4.

Comment 1

17 years ago
In the source of http://www.mp3-tech.org/mainpage.html you can see that there
are two encapsulated framesets where the outer has border="false" and the like
but the inner has not. I think the border comes from the second frameset.

According to HTML standards you should have a frameborder="0" and the like on
the frames themselves.
No, descendants should get the frame width and existence from ancestors.  This
inheritance was broken when code was moved from Reflow() to Init()

I've got a fix that's 90% right.  I'll attach a patch as soon as I finish
ironing out the last 10%.
Assignee: asa → bzbarsky
Status: UNCONFIRMED → NEW
Component: Browser-General → Layout
Ever confirmed: true
Keywords: regression
OS: Windows 2000 → All
Hardware: PC → All
hyatt, would you review?
Status: NEW → ASSIGNED
Keywords: patch, review
Priority: -- → P1
Target Milestone: --- → mozilla0.9.6
Created attachment 56564 [details] [diff] [review]
Patch v.2 (comments from timeless)

Updated

17 years ago
Attachment #56564 - Flags: review+
Created attachment 56565 [details] [diff] [review]
same but add a missing ")" so it builds.  :)

Comment 7

17 years ago
Comment on attachment 56565 [details] [diff] [review]
same but add a missing ")" so it builds.  :)

sr=attinasi
Attachment #56565 - Flags: superreview+

Comment 8

17 years ago
Comment on attachment 56565 [details] [diff] [review]
same but add a missing ")" so it builds.  :)

whoops, yeah i see it.
Attachment #56565 - Flags: review+

Updated

17 years ago
Attachment #56564 - Attachment is obsolete: true
Attachment #56564 - Flags: review+

Updated

17 years ago
Attachment #56300 - Attachment is obsolete: true
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.