Closed Bug 1081658 Opened 10 years ago Closed 10 years ago

[2.1] Device specific strings like "Reset phone" not localized in some locales

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.1 verified, b2g-v2.2 unaffected)

VERIFIED FIXED
2.1 S7 (24Oct)
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- unaffected

People

(Reporter: aryx, Assigned: chens)

References

Details

(Keywords: regression)

Attachments

(1 file)

[Blocking Requested - why for this release]: +++ This bug was initially created as a clone of Bug #1074166 +++ Flame-KK with 2.1 20141011160202, Gaia commit f5d4ff60 Prerequisite Have the phone in another language (tested with German and Spanish). STR 1. Go to settings -> Information 2. Scroll at the bottom of the page Actual result The button shows "Reset phone" for German and Spanish, but is localized in the other languages I tried (Albanian, Czech, Danish, Dutch, French, Italian, Lithuanian, Slovak). Expected The button should show the localized string like in 2.0 The de.json from the folder locales-obj of the application.zip belonging to Settings has the strings in English despite German being completely translated for weeks. [Blocking Requested - why for this release]: Regression + Non-localizable strings
So, Spanish is actually just not translated, so that's OK. German is translated, but the devices files don't end up in build_stage. I'd search for something that confuses 'devices' with 'de'. Sherman, can you take a look?
Flags: needinfo?(shchen)
Attached file pull request
Assignee: nobody → shchen
Attachment #8503833 - Flags: review?(ricky060709)
Flags: needinfo?(shchen)
I think this will only happen on German, and Axel is right, |removeLocale| confuses 'devices' with 'de'.
Comment on attachment 8503833 [details] [review] pull request LGTM! r=@RickyChien
Attachment #8503833 - Flags: review?(ricky060709) → review+
Comment on attachment 8503833 [details] [review] pull request [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 944604 [User impact] if declined: Device specific strings are not localized correctly. [Testing completed]: Manual test + unit test. [Risk to taking this patch] (and alternatives if risky): Low risk and no alternatives. [String changes made]: None.
Attachment #8503833 - Flags: approval-gaia-v2.1?
Attachment #8503833 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S7 (24Oct)
Duane, can you verify this issue on 2.1 please?
QA Whiteboard: [QAnalyst-Triage-]
Flags: needinfo?(ddixon)
Verifying as fixed with Flame-kk 20141014001201 (Gaia commit 7e2e65a9 2014-10-13)
Status: RESOLVED → VERIFIED
Flags: needinfo?(ddixon)
Issue is NOT fixed in Flame 2.1 (Full Flash, Nightly) Actual Results: "Reset Phone" button in Settings App is correctly localized in German, but is NOT localized correctly in Spanish in latest Flame 2.1 build. Note: The "Reset Phone" button is correctly localized in latest Flame 2.2 build in both German and Spanish. Device: Flame 2.1 Build ID: 20141014001201 Gaia: 7e2e65a9668123b54c8cce5dacfdba6f4bd4672b Gecko: 2325da834971 Version: 34.0 (2.1) Firmware Version: v180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: VERIFIED → RESOLVED
Closed: 10 years ago10 years ago
QA Whiteboard: [QAnalyst-Triage-] → [QAnalyst-Triage?] [failed-verification]
Flags: needinfo?(ktucker)
Archaeopteryx, can you double check Spanish on 2.1? We are seeing different results.
Flags: needinfo?(ktucker) → needinfo?(archaeopteryx)
QA Whiteboard: [QAnalyst-Triage?] [failed-verification] → [QAnalyst-Triage+] [failed-verification]
The actual translations only landed yesterday, should be in today's build.
Flags: needinfo?(archaeopteryx)
Duane, please recheck this on today's 2.1.
Flags: needinfo?(ddixon)
Verifying that issue is now fixed on today's 2.1 Flame build (Full Flash, Nightly). Actual Results: The "Reset Phone" button is correctly localized when language is set to Spanish. Environmental Variables: Device: Flame 2.1 Build ID: 20141015001201 Gaia: 379ea4c9dd6d3f8ca2f79ce59c15f6afe6e557c3 Gecko: 4853208cb48a Version: 34.0 (2.1) Firmware Version: v180 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] [failed-verification] → [QAnalyst-Triage?]
Flags: needinfo?(ddixon) → needinfo?(ktucker)
Keywords: verifyme
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Since this landed in 2.1 and was verified-fixed, removing off the 2.1? flag
blocking-b2g: 2.1? → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: