1081684 - [Build] Themes don't load when running in Firefox

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Since we use app://theme to load the theme CSS file (bug 1069840), we don't have it in Firefox.

Comment 1

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Attachment: github PR

Hey Ricky,

We rely on launching the SMS app in Firefox and without this the header is black on white.

I don't know if this is the best way to solve the issue but this is reasonnably simple. Maybe in httpd.js I could use a mapping array instead of a if.

Comment 2

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

To launch the SMS app in Firefox:

PROFILE_FOLDER=profile-sms DEBUG=1 DESKTOP=0 make
<path to firefox>/firefox --no-remote -profile profile-sms app://sms.gaiamobile.org/

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Patch seems to be no problem but I wonder what is the difference after applying it.
Could you upload a before/after screenshot? Thanks!

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8503767 [details] [review]
github PR

Though I cannot see effect in new theme, I ensure that http://theme.gaiamobile.org:8080/shared/elements/gaia-theme/gaia-theme.css has been loaded properly.

Let's land it!

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Attachment: before patch

Comment 6

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Attachment: after patch

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

master: 2543927ea3bfa7ec23d4e9241f62c157e6b128d1

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Cool!

I saw these changes in b2g but the result on firefox/nightly was broken. I guess it's a firefox/nightly issue.

Comment 9

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Yep, it's an issue only when using httpd.js (because we use our own handler for app://). Maybe a cleaner solution could be to be able to reuse the app:// handler we use in B2G.

Comment 10

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

bug 1069840 landed in v2.1 so we need this in v2.1 as well.
a=npotb
v2.1: daef1ae65560cd38d652f3665568086a1c9f1b9e