Closed
Bug 1081692
Opened 9 years ago
Closed 9 years ago
Move TreeColumn to WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file, 2 obsolete files)
15.19 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Be aware of bug 979835, which also touches some stuff around here.
Assignee | ||
Comment 2•9 years ago
|
||
Thanks for the hint, but I don't see any obvious problem. The GetElement implementation gave my slight headaches.
Assignee | ||
Comment 3•9 years ago
|
||
Having both Primary() and IsPrimary() etc. is probably not useful.
Assignee | ||
Updated•9 years ago
|
Attachment #8503782 -
Attachment is patch: true
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8503781 -
Attachment is obsolete: true
Attachment #8503782 -
Attachment is obsolete: true
Attachment #8504097 -
Flags: review?(khuey)
Comment 5•9 years ago
|
||
Please also be aware of bug 441414. I think this will cause some conflicts over there too.
Comment 6•9 years ago
|
||
(In reply to Alex Vincent [:WeirdAl] from comment #5) > Please also be aware of bug 441414. I think this will cause some conflicts > over there too. It's OK, I'll rebase it, does the mozilla community start to migrate all the IDLs to webidl?
Comment on attachment 8504097 [details] [diff] [review] v1 - Move to WebIDL Review of attachment 8504097 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/xul/tree/nsTreeColumns.h @@ +54,5 @@ > + virtual JSObject* WrapObject(JSContext* aCx) MOZ_OVERRIDE; > + > + mozilla::dom::Element* GetElement(mozilla::ErrorResult& aRv); > + > + nsTreeColumns* GetColumns() { return mColumns; } Mark all of these simple getters const.
Attachment #8504097 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 8•9 years ago
|
||
I had to make a few adjustments after the TreeBoxObject change, but I showed the diff to Kyle on IRC. https://hg.mozilla.org/integration/mozilla-inbound/rev/21ea52a1c31d
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/21ea52a1c31d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•