1081692 - Move TreeColumn to WebIDL

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Be aware of bug 979835, which also touches some stuff around here.

Comment 2

[Tom S [:evilpie]]

Attachment: v1

Thanks for the hint, but I don't see any obvious problem. The GetElement implementation gave my slight headaches.

Comment 3

[Tom S [:evilpie]]

Attachment: v1 - Part 2 Move to new WebIDL functions

Having both Primary() and IsPrimary() etc. is probably not useful.

Comment 4

[Tom S [:evilpie]]

Attachment: v1 - Move to WebIDL

Comment 5

[Alex Vincent [:WeirdAl]]

Please also be aware of bug 441414.  I think this will cause some conflicts over there too.

Comment 6

[Yonggang Luo]

(In reply to Alex Vincent [:WeirdAl] from comment #5)
> Please also be aware of bug 441414.  I think this will cause some conflicts
> over there too.

It's OK, I'll rebase it, does the mozilla community start to migrate all the IDLs to webidl?

Comment 7

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8504097 [details] [diff] [review]
v1 - Move to WebIDL

Review of attachment 8504097 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/xul/tree/nsTreeColumns.h
@@ +54,5 @@
> +  virtual JSObject* WrapObject(JSContext* aCx) MOZ_OVERRIDE;
> +
> +  mozilla::dom::Element* GetElement(mozilla::ErrorResult& aRv);
> +
> +  nsTreeColumns* GetColumns() { return mColumns; }

Mark all of these simple getters const.

Comment 8

[Tom S [:evilpie]]

I had to make a few adjustments after the TreeBoxObject change, but I showed the diff to Kyle on IRC.
https://hg.mozilla.org/integration/mozilla-inbound/rev/21ea52a1c31d

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/21ea52a1c31d