Move TreeColumn to WebIDL

RESOLVED FIXED in mozilla36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla36
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
Be aware of bug 979835, which also touches some stuff around here.
(Assignee)

Comment 2

4 years ago
Created attachment 8503781 [details] [diff] [review]
v1

Thanks for the hint, but I don't see any obvious problem. The GetElement implementation gave my slight headaches.
(Assignee)

Comment 3

4 years ago
Created attachment 8503782 [details] [diff] [review]
v1 - Part 2 Move to new WebIDL functions

Having both Primary() and IsPrimary() etc. is probably not useful.
(Assignee)

Updated

4 years ago
Attachment #8503782 - Attachment is patch: true
(Assignee)

Comment 4

4 years ago
Created attachment 8504097 [details] [diff] [review]
v1 - Move to WebIDL
Attachment #8503781 - Attachment is obsolete: true
Attachment #8503782 - Attachment is obsolete: true
Attachment #8504097 - Flags: review?(khuey)
Please also be aware of bug 441414.  I think this will cause some conflicts over there too.

Comment 6

4 years ago
(In reply to Alex Vincent [:WeirdAl] from comment #5)
> Please also be aware of bug 441414.  I think this will cause some conflicts
> over there too.

It's OK, I'll rebase it, does the mozilla community start to migrate all the IDLs to webidl?
Comment on attachment 8504097 [details] [diff] [review]
v1 - Move to WebIDL

Review of attachment 8504097 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/xul/tree/nsTreeColumns.h
@@ +54,5 @@
> +  virtual JSObject* WrapObject(JSContext* aCx) MOZ_OVERRIDE;
> +
> +  mozilla::dom::Element* GetElement(mozilla::ErrorResult& aRv);
> +
> +  nsTreeColumns* GetColumns() { return mColumns; }

Mark all of these simple getters const.
Attachment #8504097 - Flags: review?(khuey) → review+
(Assignee)

Comment 8

4 years ago
I had to make a few adjustments after the TreeBoxObject change, but I showed the diff to Kyle on IRC.
https://hg.mozilla.org/integration/mozilla-inbound/rev/21ea52a1c31d
(Assignee)

Updated

4 years ago
Blocks: 1084304
https://hg.mozilla.org/mozilla-central/rev/21ea52a1c31d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.