Closed
Bug 1081694
Opened 10 years ago
Closed 10 years ago
build failure on non-skia platforms
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: stevensn, Assigned: stevensn)
References
Details
Attachments
(1 file)
1.37 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Bug 1066280 introduced some changes to CanvasRenderingContext2D that broke non skia GL platforms 6:11.22 /home/buildbot/buildbot/slave/runtests/build/dom/canvas/CanvasRenderingContext2D.cpp: In member function ‘virtual void mozilla::dom::CanvasRenderingContext2D::DidRefresh()’: 6:11.22 /home/buildbot/buildbot/slave/runtests/build/dom/canvas/CanvasRenderingContext2D.cpp:1027:19: error: invalid use of incomplete type ‘class mozilla::gl::SkiaGLGlue’ 6:11.22 auto gl = glue->GetGLContext(); among other failures. SkiaGLGlue.h has a ! USE_SKIA_GPU section in it. Maybe we should move the SkiaGLGlue.h include outside the USE_SKIA ifdef
Assignee | ||
Comment 1•10 years ago
|
||
I'm not sure if adding gfx/gl to the moz.config is right or if we should be exporting that from a different moz.build
Assignee | ||
Comment 2•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=a636a2be3ee2
Assignee | ||
Updated•10 years ago
|
Attachment #8503779 -
Flags: review?(jgilbert)
Updated•10 years ago
|
Attachment #8503779 -
Flags: review?(jgilbert) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3f97d35b180
Assignee: nobody → steve
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f3f97d35b180
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•