1081711 - "Remember this decision" does not work for choosing a client certificate on Firefox for Android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Weeks]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Build ID: 20140923175406

Steps to reproduce:

1. Visit site to issue certificate (https://scriptjunkie.us/getacert)
2. Tap the Generate button to get a certificate (and you are issued one)
3. Tap the link to https://www.scriptjunkie.us/auth/verifycert to use your certificate
"User Identification Request" prompt shows up, lists our certificate, has checkbox to "Remember this decision".
4. Leave checkbox selected to remember this decision and tap OK
5. Wait a few seconds.
6. Refresh the page or close tab and re-open or go back to the getacert page and tap the link to the verifycert page and you'll be prompted again to make the same decision.


Actual results:

You get prompted to choose a certificate every time you visit a site or URL that requests one.


Expected results:

Firefox should have remembered your choice, since you selected remember.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

I actually took a look at it yesterday. The bug is on this line [1], | response.rememberBox | is true, but true != "true" in JS, so the comparison fails. Really simple to fix.

http://mxr.mozilla.org/mozilla-central/source/mobile/android/components/NSSDialogService.js?rev=313e5dcdfcb8#203

Comment 2

[Mark Goodwin [:mgoodwin]]

Attachment: bug1081711

changed "true" to true as per comment #1

Comment 3

[Mark Goodwin [:mgoodwin]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b129469fada0

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/04a67df19cd2

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Once this bakes a bit, we should ask for approval on aurora and beta

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/04a67df19cd2

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: consider this for uplift into beta

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Pretty simple one-line fix, not sure we need to track this since it's not clear this is a regression instead of a long term issue.  Please nominate for approval uplift so it can be considered on the basis of stability and risk.

Comment 9

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8509767 [details] [diff] [review]
bug1081711

Approval Request Comment
[Feature/regressing bug #]: 1081711
[User impact if declined]: Users will have to re-select client certs for each visit to a site
[Describe test coverage new/current, TBPL]: No new or existing test coverage
[Risks and why]: Minimal; single line change to a line of code that never worked anyway.
[String/UUID change made/needed]: no.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/431266bc5e4d
https://hg.mozilla.org/releases/mozilla-beta/rev/f953384743a4

Comment 11

[u421692]

Verified as fixed on all Firefox channels on Nexus 5(Android 5.0)

Comment 12

[Ogawa Tatsuya]

Attachment: patch of NSSDialogService.js

Trust SSL may be also correct.