1081748 - [Contacts] Deleting a comment on a contact collapses the whole comment thread on edit screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20141012_CommentBoxesCollapse.txt

Description:
When the user deletes one of multiple comments on a contact, the whole comment thread collapses instead of deleting the comment only.
   
Pre-requisite: Have a contact added with at least 2 comments.

Repro Steps:
1) Update a Flame device to BuildID: 20141012001201.
2) Open Contacts app.
3) Select the contact with multiple comments.
4) Tap the edit icon in the upper right corner.
5) Scroll down to the comment boxes, and tap the red delete icon next to one of the comments.
  
Actual:
All comment boxes collapses. 
  
Expected: 
The only deleted comment box disappears. All remaining comment boxes stay on the screen.

Note:
The remaining comment boxes do NOT get deleted. When the user taps "Add Comment" after step 5, the remaining comments are shown.
  
Flame 2.1 

Device: Flame 2.1 KK (319mb) (Full Flash)
BuildID: 20141012001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Repro frequency: 100%
See attached: logcat, video
http://youtu.be/6wWiIVZe6-4

Comment 1

[Yeojin Chung [:YeojinC]]

This issue does NOT occur on Flame 2.2:

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141012040203
Gaia: 717ad4e8b7fc10ab8248500d00ba5ba0977fa8ab
Gecko: 44168a7af20d
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

The only deleted comment box disappears. All remaining comment boxes stay on the screen.
-----------------------------------------------
This issue does not occur on Flame 2.0, since the issue involves with the new UI on the contact edit screen AFTER 2.0:

Device: Flame 2.0 KK (319mb) (Full Flash)
BuildID: 20141012000202
Gaia: 6effca669c5baaf6cd7a63c91b71a02c6bd953b3
Gecko: 54ec9cb26b59
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Confusing behavior on a new feature (collapsing entries in Edit Page).

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Sergi, is this familiar to you?

Comment 4

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

No, but I can take a look.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Not a blocker, but definitely a nice to have in 2.1

Please prioritise and ask for approval.

Comment 6

[Jose Manuel Cantera]

I've fixed this bug in 2.2 but It didn't get the approval

Comment 7

[Jose Manuel Cantera]

(In reply to Jose Manuel Cantera from comment #6)
> I've fixed this bug in 2.2 but It didn't get the approval

I rectify myself. bug 1068098 got the approval but it was not properly uplifted due to a Ryan's mistake. Closing this and ni Ryan to get his attention on the other bug

Comment 8

[Jose Manuel Cantera]

We need to reopen this as per bug 1068098 comment #15

Comment 9

[Jose Manuel Cantera]

Attachment: Patch for v2.1 to be directly merged

Comment 10

[KTucker [:KTucker][Inactive 3/4/2016]]

As stated in comment 5 not a blocker but definitely confusing behavior for the end user and probably should be fixed on 2.1.

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8504752 [details]
Patch for v2.1 to be directly merged

Working perfectly in 2.1

Comment 12

[Jose Manuel Cantera]

Comment on attachment 8504752 [details]
Patch for v2.1 to be directly merged

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Visual Refresh Contacts Edit
[User impact] if declined: Relatively high. Confusing behavior
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low risk patch
[String changes made]: None

Comment 13

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/7adae3eda2d51530477092ca0e36af3acde4826d

Comment 14

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.1.

Result: The only deleted comment box disappears. All remaining comment boxes stay on the screen.

Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141024001204
Gaia: 0f76e0baac733cca56d0140e954c5f446ebc061f
Gecko: 7d78ff7d25b6
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0