Closed
Bug 1081766
Opened 10 years ago
Closed 10 years ago
clean up MediaSourceReader/TrackBuffer shutdown a bit
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: karlt, Assigned: karlt)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
1.70 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
983 bytes,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
1.11 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
1.11 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
1.90 KB,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
TrackBuffer::Shutdown() is run from MediaSourceReader::Shutdown(), while the MDStateMachine shuts down its mDecodeTaskQueue. MediaSourceReader::BreakCycles() later runs on the main thread from MDStateMachine's nsDecoderDisposeEvent. It tries to call BreakCycles on each TrackBuffer, but mTrackBuffers is already empty from Shutdown. TrackBuffer::BreakCycles() would try to call BreakCycles on mDecoders[i]->GetReader(), but mDecoders is already empty from Shutdown().
Assignee | ||
Comment 1•10 years ago
|
||
Clearing tracks after Shutdown of TrackBuffers means they are cleared after any more can be added.
Attachment #8503838 -
Flags: review?(kinetik)
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8503839 -
Flags: review?(kinetik)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8503840 -
Flags: review?(kinetik)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8503841 -
Flags: review?(kinetik)
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8503842 -
Flags: review?(kinetik)
Assignee | ||
Comment 6•10 years ago
|
||
I don't know of real problems fixed in these patches. They provide that BreakCycles will run on the readers, make it clearer what happens when, and simplify the code a little.
Updated•10 years ago
|
Attachment #8503838 -
Flags: review?(kinetik) → review+
Updated•10 years ago
|
Attachment #8503839 -
Flags: review?(kinetik) → review+
Updated•10 years ago
|
Attachment #8503840 -
Flags: review?(kinetik) → review+
Updated•10 years ago
|
Attachment #8503841 -
Flags: review?(kinetik) → review+
Updated•10 years ago
|
Attachment #8503842 -
Flags: review?(kinetik) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5eca3f1dee8 https://hg.mozilla.org/integration/mozilla-inbound/rev/3a3d2d09ccca https://hg.mozilla.org/integration/mozilla-inbound/rev/bfd5484930fd https://hg.mozilla.org/integration/mozilla-inbound/rev/e4e161c1604f https://hg.mozilla.org/integration/mozilla-inbound/rev/100285c306d0
Flags: in-testsuite-
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a5eca3f1dee8 https://hg.mozilla.org/mozilla-central/rev/3a3d2d09ccca https://hg.mozilla.org/mozilla-central/rev/bfd5484930fd https://hg.mozilla.org/mozilla-central/rev/e4e161c1604f https://hg.mozilla.org/mozilla-central/rev/100285c306d0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•