[RFE] Implement batched reflows.

VERIFIED FIXED in M14

Status

()

Core
Layout
P3
enhancement
VERIFIED FIXED
19 years ago
9 months ago

People

(Reporter: Chris Waterson, Assigned: Nisheeth Ranjan)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

19 years ago
Per our (vidur/nisheeth/waterson/hyatt) discussion today about batching reflows
from RDF and mail/news, I'm logging this bug. For context, see
news://news.mozilla.org/37A0A56F.652A084A%40netscape.com.
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
Summary: batch reflows → [RFE] Implement batched reflows.
(Assignee)

Updated

19 years ago
Target Milestone: M11
(Assignee)

Comment 1

19 years ago
Accepting bug and setting milestone to M11 for now...
(Assignee)

Updated

18 years ago
Target Milestone: M11 → M12
(Assignee)

Comment 2

18 years ago
Accepting bug and setting milestone to M12...
(Assignee)

Comment 3

18 years ago
I accidentally made the earlier comment.  It was meant for another bug
that I wanted to fix in M12.  Chris, is this bug a beta stopper?  I know you
worked around the performance problem in the tree widget.  If at all possible,
I'd like to move this out beyond beta.
(Reporter)

Comment 4

18 years ago
yeah, i think that's ok.
(Assignee)

Updated

18 years ago
Target Milestone: M12 → M15
(Assignee)

Comment 5

18 years ago
Setting target milestone to M15...
(Assignee)

Comment 6

18 years ago
Moving this in to M14.  I'm going to add methods for batching reflows on the 
pres shell.  
Target Milestone: M15 → M14

Comment 7

18 years ago
You're my hero, stoner. :)
(Assignee)

Comment 8

18 years ago
Man, if this name sticks, I'm never gonna get a job *anywhere* else!  :)
(Assignee)

Comment 9

18 years ago
Attaching a patch that adds batching to the PresShell.  Could one of you please 
code review it.  Thanks!
(Assignee)

Comment 10

18 years ago
Created attachment 4574 [details] [diff] [review]
Patch to batch reflows

Comment 11

18 years ago
Hey that's great, Hyatt's calling you stoner now, too!

Comment 12

18 years ago
Looks okay, but I have a couple of suggestions:

- maybe we should name them BeginBatchingReflows/EndBatchingReflows instead? I 
think that's the terminology we use elsewhere, e.g., the document observer API
- IsBatchingReflows() might better be GetReflowBatchingStatus(). That would give 
you more flexibility to add additional status down the line

You need to define how the semantics for batching works. In particular, the 
usage model. The way it is now it's meant for a single user at a time and 
the begin/end batching calls should not occur across a flow of control.

Things will get wacky if someone begins batching, leaves the batching open, then 
 a different client (like the HTML content sink) either begins batching or 
starts adding reflow commands thinking they will be processed immediately

At a minimum, for the time being StartBatchingReflows() should probably assert 
that mBatchReflows is FALSE
(Assignee)

Comment 13

18 years ago
I've incorporated Troy's suggestions into the patch and will check it in today 
once the tree opens.
(Assignee)

Comment 14

18 years ago
I just checked this in.  Marking fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 15

18 years ago
Marking verified per last comments.
Status: RESOLVED → VERIFIED

Comment 16

15 years ago
[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.
Severity: normal → enhancement
You need to log in before you can comment on or make changes to this bug.