Closed Bug 10818 Opened 21 years ago Closed 20 years ago

[RFE] Implement batched reflows.


(Core :: Layout, enhancement, P3)






(Reporter: waterson, Assigned: nisheeth_mozilla)



(1 file)

Per our (vidur/nisheeth/waterson/hyatt) discussion today about batching reflows
from RDF and mail/news, I'm logging this bug. For context, see
Summary: batch reflows → [RFE] Implement batched reflows.
Target Milestone: M11
Accepting bug and setting milestone to M11 for now...
Target Milestone: M11 → M12
Accepting bug and setting milestone to M12...
I accidentally made the earlier comment.  It was meant for another bug
that I wanted to fix in M12.  Chris, is this bug a beta stopper?  I know you
worked around the performance problem in the tree widget.  If at all possible,
I'd like to move this out beyond beta.
yeah, i think that's ok.
Target Milestone: M12 → M15
Setting target milestone to M15...
Moving this in to M14.  I'm going to add methods for batching reflows on the 
pres shell.  
Target Milestone: M15 → M14
You're my hero, stoner. :)
Man, if this name sticks, I'm never gonna get a job *anywhere* else!  :)
Attaching a patch that adds batching to the PresShell.  Could one of you please 
code review it.  Thanks!
Hey that's great, Hyatt's calling you stoner now, too!
Looks okay, but I have a couple of suggestions:

- maybe we should name them BeginBatchingReflows/EndBatchingReflows instead? I 
think that's the terminology we use elsewhere, e.g., the document observer API
- IsBatchingReflows() might better be GetReflowBatchingStatus(). That would give 
you more flexibility to add additional status down the line

You need to define how the semantics for batching works. In particular, the 
usage model. The way it is now it's meant for a single user at a time and 
the begin/end batching calls should not occur across a flow of control.

Things will get wacky if someone begins batching, leaves the batching open, then 
 a different client (like the HTML content sink) either begins batching or 
starts adding reflow commands thinking they will be processed immediately

At a minimum, for the time being StartBatchingReflows() should probably assert 
that mBatchReflows is FALSE
I've incorporated Troy's suggestions into the patch and will check it in today 
once the tree opens.
I just checked this in.  Marking fixed.
Closed: 20 years ago
Resolution: --- → FIXED
Marking verified per last comments.
[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.
Severity: normal → enhancement
You need to log in before you can comment on or make changes to this bug.