Closed
Bug 1081810
Opened 10 years ago
Closed 10 years ago
Implement IccCardLockError in C++
Categories
(Firefox OS Graveyard :: RIL, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S7 (24Oct)
People
(Reporter: edgar, Assigned: edgar)
References
Details
Attachments
(2 files, 2 obsolete files)
7.75 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
1.20 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
forgot to `hg qrefresh`, upload correct version includes all changes.
Attachment #8503972 -
Attachment is obsolete: true
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → echen
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8503978 [details] [diff] [review] Patch, v2 Move JS-implemented IccCardLockError to C++. Hi Olli, may I have your review? Thank you.
Attachment #8503978 -
Flags: review?(bugs)
Comment 4•10 years ago
|
||
Comment on attachment 8503978 [details] [diff] [review] Patch, v2 ahaa, so we don't currently use the .webidl on desktop because of MOZ_B2G_RIL check in moz.build. I was wondering why Pref="dom.icc.enabled". Looks fine. Why ChromeConstructor? DOMError has normal Constructor and I don't see any reason to change Constructor to ChromeConstructor, at least not in this patch. So if you undo that change, r+. Does anyone else still call DOMError.init ? Perhaps DOMMMI* stuff does still. (Otherwise we could get rid of that ChromeOnly init)
Attachment #8503978 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #4) > Comment on attachment 8503978 [details] [diff] [review] > Patch, v2 > > ahaa, so we don't currently use the .webidl on desktop because of > MOZ_B2G_RIL check in moz.build. I was wondering why Pref="dom.icc.enabled". > Looks fine. Yup, it is guarded by MOZ_B2G_RIL right now, but we plan to remove MOZ_B2G_RIL and use preference to control it in bug 947116. And all other Icc related webidls have Pref="dom.icc.enabled" now actually, so add it in this bug. > > Why ChromeConstructor? DOMError has normal Constructor and I don't see > any reason to change Constructor to ChromeConstructor, at least not in this > patch. So if you undo that change, r+. Okay, will undo the change for Constructor. > > > Does anyone else still call DOMError.init ? Perhaps DOMMMI* stuff does still. > (Otherwise we could get rid of that ChromeOnly init) DOMMMIError was moved to C++ in Bug 929701. We could get rid of DOMError.init. Will provide a patch for this. Thank you.
Assignee | ||
Comment 6•10 years ago
|
||
Address review comment #5. - undo the change for Constructor.
Attachment #8503978 -
Attachment is obsolete: true
Attachment #8504529 -
Flags: review+
Assignee | ||
Comment 7•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8504530 -
Flags: review?(bugs)
Comment 8•10 years ago
|
||
Comment on attachment 8504530 [details] [diff] [review] Part 2: Get rid of DOMError.init, v1 r+ assuming you've checked there are no callers.
Attachment #8504530 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 9•10 years ago
|
||
(In reply to Olli Pettay [:smaug] from comment #8) > Comment on attachment 8504530 [details] [diff] [review] > Part 2: Get rid of DOMError.init, v1 > > r+ assuming you've checked there are no callers. Yes, I have checked there are no callers. Thank you.
Assignee | ||
Comment 10•10 years ago
|
||
Try result: https://tbpl.mozilla.org/?tree=Try&rev=bf1066b9f396
Assignee | ||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/547119c53310 https://hg.mozilla.org/integration/b2g-inbound/rev/511be093541f
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/547119c53310 https://hg.mozilla.org/mozilla-central/rev/511be093541f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S7 (24Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•