[RTSP] Remove resume and suspend from IPDL of RtspController

RESOLVED WONTFIX

Status

Firefox OS
RTSP
--
enhancement
RESOLVED WONTFIX
4 years ago
2 years ago

People

(Reporter: ethan, Assigned: ethan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

4 years ago
This is a follow-up of bug 1080470.

Pause/suspend and play/resume have different meaning in MediaDecoder.
However, for RTSP controller stack, suspend is equal to pause and resume is equal
to play.
The current implementation of RTSP controller's suspend and resume functions call
its pause and play, respectively. We should remove suspend and resume from the
IPDL of RTSP controller to avoid confusion and hence improve maintainability.
(Assignee)

Updated

4 years ago
Assignee: nobody → ettseng
(Assignee)

Comment 1

4 years ago
Hi Vincent and Benjamin,

AFAIK, suspend/resume in RTSP controller are equal to pause/play.

I tend to do the following:
1) Remove suspend/resume methods from PRtspController.ipdl.
2) Remove RecvSuspend/RecvResume() from RtspControllerParent.h/cpp.

We can keep suspend/resume() methods in nsIStreamingProtocolController.idl.
This IDL was designed to be a general interface of media stream controller, although it's only used in
RTSP streaming.

Do you have any concern about it?
Flags: needinfo?(vchang)
Flags: needinfo?(bechen)
I don't think we should remove suspend/resume APIs. We could do something better than pause/play to reduce power consumption.
Flags: needinfo?(vchang)
(Assignee)

Updated

4 years ago
Severity: normal → enhancement
(In reply to Vincent Chang[:vchang] from comment #2)
> I don't think we should remove suspend/resume APIs. We could do something
> better than pause/play to reduce power consumption.

Do you mean that if we are going to suspend state(user press home key or power key), after a while, the network connection should be disconnected? 
Then resume the rtsp, we should able to recreate the network connection and seek to the right position?
Flags: needinfo?(bechen)
(Assignee)

Comment 4

2 years ago
No one is actually working on RTSP for FxOS right now.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.