Closed
Bug 1081860
Opened 10 years ago
Closed 10 years ago
[NFC][KK] Wording on shrinking UI truncate when keyboard shows up
Categories
(Firefox OS Graveyard :: NFC, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.2 verified)
People
(Reporter: ashiue, Assigned: gduan)
References
Details
Attachments
(4 files)
Gaia-Rev f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1 Gecko-Rev https://hg.mozilla.org/releases/mozilla-aurora/rev/75cd3a8fa031 Build-ID 20141012160202 Version 34.0a2 STR: 1. Enable NFC on both phones 2. Open a website and focus on textbox that would show keyboard 3. Tap 2 phones together and check the shrinking UI Expect result: Shrinking UI shows normal Actual result: Wording on shrinking UI truncate when keyboard shows up
Reporter | ||
Comment 1•10 years ago
|
||
[Blocking Requested - why for this release]: obvious error
blocking-b2g: --- → 2.1?
QA Whiteboard: [COM=NFC]
Blocks: NFC-Gaia
Reporter | ||
Comment 2•10 years ago
|
||
https://moztrap.mozilla.org/manage/cases/?filter-id=14794
Flags: in-moztrap+
Assignee | ||
Comment 3•10 years ago
|
||
Hi Alive, could you take a look at this patch? I would suggest to hide keyboard while shrinking ui is launched. And I also try to make the focused item blurred while calling hideKeyboardImmediately .
Attachment #8504178 -
Flags: review?(alive)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gduan
Comment 4•10 years ago
|
||
Comment on attachment 8504178 [details] [review] PR to master WFM, not sure about the blur, flag keyboard owner to feedback
Attachment #8504178 -
Flags: review?(alive)
Attachment #8504178 -
Flags: review+
Attachment #8504178 -
Flags: feedback?(rlu)
Comment 5•10 years ago
|
||
Comment on attachment 8504178 [details] [review] PR to master Looks like a workaround to me, as we already support the behavior that keeping the input field focused when going back and forth. (i.e. the input field will be kept focused, when you go to homescreen and then come back to the app with the input) I would suggest we do one of the following 2 things if possible, 1. File a platform bug that clicking on an input field should bring the keyboard again. 2. Make sure the focus is kept and the keyboard would show up again while the shrinking UI has ended.
Attachment #8504178 -
Flags: feedback?(rlu) → feedback-
Assignee | ||
Comment 6•10 years ago
|
||
I agree with Rudy, I should file a bug for platform. Inputmethod-contextchange should be able retriggered.
Comment 7•10 years ago
|
||
triage: high user impact so let's block it. The keyboard in the shrinking UI still takes input, and that makes user very difficult to complete the action "share".
Blocks: b2g-NFC-2.1
blocking-b2g: 2.1? → 2.1+
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8504178 [details] [review] PR to master Hi Alive, could I have your feedback on this patch before implementing test? I've remove part of my code in bug 1064648 and modify some for shrinking ui case. I just tested and it seems work fine on this bug and bug 1064648.
Attachment #8504178 -
Flags: feedback- → feedback?(alive)
Updated•10 years ago
|
Attachment #8504178 -
Flags: feedback?(alive) → feedback+
Assignee | ||
Comment 9•10 years ago
|
||
Thanks, master: https://github.com/mozilla-b2g/gaia/commit/a18559e844b6aec946309a3bee6a32ca06ab4649
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 10•10 years ago
|
||
Hi George, could you please uplift this bug to 2.1?
Flags: needinfo?(gduan)
Assignee | ||
Comment 11•10 years ago
|
||
In this PR, I didn't remove the change from bug 1064648, because 2.1 won't focus on the input field again when the app shows on the foreground. [Approval Request Comment] [Bug caused by] (feature/regressing bug #): No [User impact] if declined: User will see attachment 8503969 [details] when keyboard and shrinkingUI is launched. [Testing completed]: Yes. [Risk to taking this patch] (and alternatives if risky): No. [String changes made]:
Flags: needinfo?(gduan)
Attachment #8506674 -
Flags: approval-gaia-v2.1?
Updated•10 years ago
|
Attachment #8506674 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Comment 12•10 years ago
|
||
Looks like the v2.1 patch has test failures: https://treeherder.mozilla.org/ui/logviewer.html#?job_id=226436&repo=gaia-try
status-b2g-v2.1:
--- → affected
status-b2g-v2.2:
--- → fixed
Flags: needinfo?(gduan)
Target Milestone: --- → 2.1 S7 (24Oct)
Assignee | ||
Comment 13•10 years ago
|
||
From my understanding, my commit should not affect below failure test https://github.com/mozilla-b2g/gaia/blob/v2.1/tests/python/gaia-ui-tests/gaiatest/tests/unit/test_launch_via_manifest.py and I saw below also fail. https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=6f040862d6fd https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=05fc9acb65be https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=05edf297c13a
Flags: needinfo?(gduan)
Assignee | ||
Comment 14•10 years ago
|
||
This commit contains fix to gip of 2.1. I change the code as master branch.
Assignee | ||
Comment 15•10 years ago
|
||
Comment on attachment 8507594 [details] [review] PR to 2.1 - 2 Hi Ryan, I update some python test for the failure test you mentioned in comment 12 and believe it has failed many times(comment 13). We can merge my patch or uplift bug 1074815 to v2.1.
Flags: needinfo?(ryanvm)
Comment 16•10 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/6456e9d03a6f9a226818a1bccefc489a9bb7cb56
Flags: needinfo?(ryanvm)
Reporter | ||
Comment 17•10 years ago
|
||
Verified on [2.1] Gaia-Rev db34a4b7edc0e08ede425f21f8a5b5e161e7dda8 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/65fe0274b476 Build-ID 20141020161201 Version 34.0 [2.2] Gaia-Rev dc496d04907dd314f9736ff78bab3bd27156f79a Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/f2d7d694aae5 Build-ID 20141020160202 Version 36.0a1
You need to log in
before you can comment on or make changes to this bug.
Description
•