1081860 - [NFC][KK] Wording on shrinking UI truncate when keyboard shows up

Status: VERIFIED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Alison Shiue]

Attachment: truncate_on_shrinking_UI.png

Gaia-Rev        f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-aurora/rev/75cd3a8fa031
Build-ID        20141012160202
Version         34.0a2

STR:
1. Enable NFC on both phones
2. Open a website and focus on textbox that would show keyboard
3. Tap 2 phones together and check the shrinking UI

Expect result:
Shrinking UI shows normal

Actual result:
Wording on shrinking UI truncate when keyboard shows up

Comment 1

[Alison Shiue]

[Blocking Requested - why for this release]:
obvious error

Comment 2

[Alison Shiue]

https://moztrap.mozilla.org/manage/cases/?filter-id=14794

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Hi Alive, 
could you take a look at this patch? 
I would suggest to hide keyboard while shrinking ui is launched. And I also try to make the focused item blurred while calling hideKeyboardImmediately .

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8504178 [details] [review]
PR to master

WFM, not sure about the blur, flag keyboard owner to feedback

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8504178 [details] [review]
PR to master

Looks like a workaround to me, as we already support the behavior that keeping the input field focused when going back and forth.
(i.e. the input field will be kept focused, when you go to homescreen and then come back to the app with the input)

I would suggest we do one of the following 2 things if possible,
 1. File a platform bug that clicking on an input field should bring the keyboard again.
 2. Make sure the focus is kept and the keyboard would show up again while the shrinking UI has ended.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

I agree with Rudy, I should file a bug for platform. Inputmethod-contextchange should be able retriggered.

Comment 7

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: high user impact so let's block it.
The keyboard in the shrinking UI still takes input, and that makes user very difficult to complete the action "share".

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8504178 [details] [review]
PR to master

Hi Alive,
could I have your feedback on this patch before implementing test?
I've remove part of my code in bug 1064648 and modify some for shrinking ui case. I just tested and it seems work fine on this bug and bug 1064648.

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Thanks,
master: https://github.com/mozilla-b2g/gaia/commit/a18559e844b6aec946309a3bee6a32ca06ab4649

Comment 10

[Alison Shiue]

Hi George, could you please uplift this bug to 2.1?

Comment 11

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1

In this PR, I didn't remove the change from bug 1064648, because 2.1 won't focus on the input field again when the app shows on the foreground.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): No
[User impact] if declined: User will see attachment 8503969 [details] when keyboard and shrinkingUI is launched.
[Testing completed]: Yes.
[Risk to taking this patch] (and alternatives if risky): No.
[String changes made]:

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Looks like the v2.1 patch has test failures:
https://treeherder.mozilla.org/ui/logviewer.html#?job_id=226436&repo=gaia-try

Comment 13

[(Inactive after June) George Duan [:gduan] [:喬智]]

From my understanding, my commit should not affect below failure test

https://github.com/mozilla-b2g/gaia/blob/v2.1/tests/python/gaia-ui-tests/gaiatest/tests/unit/test_launch_via_manifest.py

and I saw below also fail.
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=6f040862d6fd
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=05fc9acb65be
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=05edf297c13a

Comment 14

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to 2.1 - 2

This commit contains fix to gip of 2.1. I change the code as master branch.

Comment 15

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8507594 [details] [review]
PR to 2.1 - 2

Hi Ryan,
I update some python test for the failure test you mentioned in comment 12 and believe it has failed many times(comment 13).

We can merge my patch or uplift bug 1074815 to v2.1.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/6456e9d03a6f9a226818a1bccefc489a9bb7cb56

Comment 17

[Alison Shiue]

Verified on 
[2.1]
Gaia-Rev        db34a4b7edc0e08ede425f21f8a5b5e161e7dda8
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/65fe0274b476
Build-ID        20141020161201
Version         34.0

[2.2]
Gaia-Rev        dc496d04907dd314f9736ff78bab3bd27156f79a
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/f2d7d694aae5
Build-ID        20141020160202
Version         36.0a1