1081914 - BookmarkingUI's CustomizableUI listener needs an onAreaNodeRegistered handler

Status: RESOLVED WONTFIX

(Firefox :: Toolbars and Customization, defect)

Description

[Luís Miguel [:quicksaver] (not reading bugmail)]

BookmarkingUI (http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-places.js) only initializes the star on widget events. But if a custom toolbar is registered later and the widget is automatically added to it, those events don't fire.

An onAreaNodeRegistered is necessary that also calls BookmarkingUI._onWidgetWasMoved() accordingly. Obviously I can do this easily within the add-on, but I'm not sure if this is something you'd want to fix for all possible similar situations within firefox code itself, so I thought I'd mention it.

(PS There are probably other native widgets that also need a similar fix when initializing, but this is the only one I've run into so far. Let me know if you think this is better fixed on firefox's side, and I'll try to round up any others if they exist.)

Comment 1

[:Gijs (he/him)]

The star portion is now fixed in the url bar / page action panel, so we don't need to do this anymore.