Closed
Bug 1081935
Opened 10 years ago
Closed 10 years ago
various UUID has to be updated for the 34 beta release
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
(Whiteboard: [qa-])
Attachments
(4 files)
1.03 KB,
patch
|
Sylvestre
:
review+
|
Details | Diff | Splinter Review |
1.16 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
1.05 KB,
patch
|
dragana
:
review+
|
Details | Diff | Splinter Review |
1022 bytes,
patch
|
Sylvestre
:
review+
keeler
:
review+
|
Details | Diff | Splinter Review |
Patches arrive soon
Assignee | ||
Comment 1•10 years ago
|
||
FYI, this is urgent!
Attachment #8504055 -
Flags: review?(surkov.alexander)
Attachment #8504055 -
Flags: review?(eitan)
Assignee | ||
Comment 2•10 years ago
|
||
Complement to comment #1: here is the faulty patch: http://hg.mozilla.org/mozilla-central/rev/abb6a2af7cb5
Assignee | ||
Comment 3•10 years ago
|
||
Change of type, I think this requires an uuid bump http://hg.mozilla.org/mozilla-central/rev/4faeea1aa6e1
Attachment #8504057 -
Flags: review?(bugs)
Attachment #8504057 -
Flags: review?(bobbyholley)
Assignee | ||
Comment 4•10 years ago
|
||
New method without UUID bump: http://hg.mozilla.org/mozilla-central/rev/4a474d70179a
Attachment #8504058 -
Flags: review?(dd.mozilla)
Attachment #8504058 -
Flags: review?(daniel)
Comment 5•10 years ago
|
||
Comment on attachment 8504057 [details] [diff] [review] nsIDOMParser.diff Sorry, should have caught this in the review.
Attachment #8504057 -
Flags: review?(bugs)
Attachment #8504057 -
Flags: review?(bobbyholley)
Attachment #8504057 -
Flags: review+
Comment 6•10 years ago
|
||
Comment on attachment 8504058 [details] [diff] [review] nsIEncodedChannel.diff Review of attachment 8504058 [details] [diff] [review]: ----------------------------------------------------------------- Thank you. sorry i am just new to this. I will not miss it next time.
Attachment #8504058 -
Flags: review?(dd.mozilla)
Attachment #8504058 -
Flags: review?(daniel)
Attachment #8504058 -
Flags: review+
Assignee | ||
Comment 7•10 years ago
|
||
New method, needs an update: http://hg.mozilla.org/mozilla-central/diff/229181c88a3c/security/manager/ssl/public/nsIX509CertList.idl
Attachment #8504077 -
Flags: review?(garrett.f.robinson+mozilla)
Attachment #8504077 -
Flags: review?(dkeeler)
Assignee | ||
Comment 8•10 years ago
|
||
Comment on attachment 8504077 [details] [diff] [review] nsIX509CertList.diff <gavin> Sylvestre: they look fine to me, go ahead and land them pending review
Attachment #8504077 -
Flags: review?(garrett.f.robinson+mozilla)
Attachment #8504077 -
Flags: review?(dkeeler)
Attachment #8504077 -
Flags: review-
Attachment #8504077 -
Flags: review+
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8504055 [details] [diff] [review] nsIAccessiblePivot.diff <gavin> Sylvestre: they look fine to me, go ahead and land them pending review
Attachment #8504055 -
Flags: review?(surkov.alexander)
Attachment #8504055 -
Flags: review?(eitan)
Attachment #8504055 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Attachment #8504077 -
Flags: review-
Assignee | ||
Comment 10•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/4736685a93da https://hg.mozilla.org/releases/mozilla-aurora/rev/cd8146dd2c1f https://hg.mozilla.org/releases/mozilla-aurora/rev/36c772e0fb03 https://hg.mozilla.org/releases/mozilla-aurora/rev/47ab999a59b8
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 11•10 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #8) > <gavin> Sylvestre: they look fine to me, go ahead and land them pending > review "pending review" meaning "leave the r? requests" so people can get to them after the fact.
Comment 12•10 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #10) > https://hg.mozilla.org/releases/mozilla-aurora/rev/4736685a93da > https://hg.mozilla.org/releases/mozilla-aurora/rev/cd8146dd2c1f > https://hg.mozilla.org/releases/mozilla-aurora/rev/36c772e0fb03 > https://hg.mozilla.org/releases/mozilla-aurora/rev/47ab999a59b8 Do these need to land on m-c as well?
Comment on attachment 8504077 [details] [diff] [review] nsIX509CertList.diff Yes, this looks correct. For the record, I did mention this in bug 1029155 comment 16.
Attachment #8504077 -
Flags: review+
Assignee | ||
Comment 14•10 years ago
|
||
Also merged in inbound (36) https://hg.mozilla.org/integration/mozilla-inbound/rev/b6ec8096e04b https://hg.mozilla.org/integration/mozilla-inbound/rev/ef37b26d1bf2 https://hg.mozilla.org/integration/mozilla-inbound/rev/ac84bf5a9048 https://hg.mozilla.org/integration/mozilla-inbound/rev/83c786296b02 and aurora, 35 (after the merge) https://hg.mozilla.org/releases/mozilla-aurora/rev/bf2a3f4de752 https://hg.mozilla.org/releases/mozilla-aurora/rev/12da5c8d4c54 https://hg.mozilla.org/releases/mozilla-aurora/rev/cef3c12c4c34 https://hg.mozilla.org/releases/mozilla-aurora/rev/635c6e2ac5b5 (yes, I know, I should I have done things in the right order :)
https://hg.mozilla.org/mozilla-central/rev/b6ec8096e04b https://hg.mozilla.org/mozilla-central/rev/ef37b26d1bf2 https://hg.mozilla.org/mozilla-central/rev/ac84bf5a9048 https://hg.mozilla.org/mozilla-central/rev/83c786296b02
Assignee: nobody → sledru
You need to log in
before you can comment on or make changes to this bug.
Description
•