Closed Bug 1081935 Opened 5 years ago Closed 5 years ago

various UUID has to be updated for the 34 beta release

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

(Whiteboard: [qa-])

Attachments

(4 files)

Patches arrive soon
FYI, this is urgent!
Attachment #8504055 - Flags: review?(surkov.alexander)
Attachment #8504055 - Flags: review?(eitan)
Complement to comment #1: here is the faulty patch: http://hg.mozilla.org/mozilla-central/rev/abb6a2af7cb5
Change of type, I think this requires an uuid bump http://hg.mozilla.org/mozilla-central/rev/4faeea1aa6e1
Attachment #8504057 - Flags: review?(bugs)
Attachment #8504057 - Flags: review?(bobbyholley)
New method without UUID bump:
http://hg.mozilla.org/mozilla-central/rev/4a474d70179a
Attachment #8504058 - Flags: review?(dd.mozilla)
Attachment #8504058 - Flags: review?(daniel)
Comment on attachment 8504057 [details] [diff] [review]
nsIDOMParser.diff

Sorry, should have caught this in the review.
Attachment #8504057 - Flags: review?(bugs)
Attachment #8504057 - Flags: review?(bobbyholley)
Attachment #8504057 - Flags: review+
Comment on attachment 8504058 [details] [diff] [review]
nsIEncodedChannel.diff

Review of attachment 8504058 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

sorry i am just new to this. I will not miss it next time.
Attachment #8504058 - Flags: review?(dd.mozilla)
Attachment #8504058 - Flags: review?(daniel)
Attachment #8504058 - Flags: review+
New method, needs an update:
http://hg.mozilla.org/mozilla-central/diff/229181c88a3c/security/manager/ssl/public/nsIX509CertList.idl
Attachment #8504077 - Flags: review?(garrett.f.robinson+mozilla)
Attachment #8504077 - Flags: review?(dkeeler)
Comment on attachment 8504077 [details] [diff] [review]
nsIX509CertList.diff

<gavin> Sylvestre: they look fine to me, go ahead and land them pending review
Attachment #8504077 - Flags: review?(garrett.f.robinson+mozilla)
Attachment #8504077 - Flags: review?(dkeeler)
Attachment #8504077 - Flags: review-
Attachment #8504077 - Flags: review+
Comment on attachment 8504055 [details] [diff] [review]
nsIAccessiblePivot.diff

<gavin> Sylvestre: they look fine to me, go ahead and land them pending review
Attachment #8504055 - Flags: review?(surkov.alexander)
Attachment #8504055 - Flags: review?(eitan)
Attachment #8504055 - Flags: review+
Attachment #8504077 - Flags: review-
Blocks: 1061861
(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> <gavin> Sylvestre: they look fine to me, go ahead and land them pending
> review

"pending review" meaning "leave the r? requests" so people can get to them after the fact.
Comment on attachment 8504077 [details] [diff] [review]
nsIX509CertList.diff

Yes, this looks correct. For the record, I did mention this in bug 1029155 comment 16.
Attachment #8504077 - Flags: review+
No longer blocks: 1082322
You need to log in before you can comment on or make changes to this bug.