Closed Bug 1081952 Opened 10 years ago Closed 10 years ago

Ensure that the background finalize state is not reset before the ArenaList state is synchronized between threads

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: ehoogeveen, Assigned: ehoogeveen)

References

Details

Attachments

(1 file, 1 obsolete file)

From bug 1080584: "Hmm, there's one edge case I think we should handle though: currently we set the BFS to BFS_DONE *before* releasing the GC lock, which potentially leaves a period before the memory barrier where allocateFromArena could see BFS == BFS_DONE."
The situation is worse than I thought, but I think we're okay after this patch. See also bug 1080584 comment #23, in particular point (4).

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=787612d4fc79
Attachment #8504075 - Flags: review?(terrence) → review+
Carrying forward r=terrence. Updated the comment and description to better reflect what's actually going on.
Attachment #8504075 - Attachment is obsolete: true
Attachment #8504160 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f9faedda0179
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Blocks: 1104904
You need to log in before you can comment on or make changes to this bug.