Closed
Bug 1081952
Opened 10 years ago
Closed 10 years ago
Ensure that the background finalize state is not reset before the ArenaList state is synchronized between threads
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: ehoogeveen, Assigned: ehoogeveen)
References
Details
Attachments
(1 file, 1 obsolete file)
1.91 KB,
patch
|
ehoogeveen
:
review+
|
Details | Diff | Splinter Review |
From bug 1080584: "Hmm, there's one edge case I think we should handle though: currently we set the BFS to BFS_DONE *before* releasing the GC lock, which potentially leaves a period before the memory barrier where allocateFromArena could see BFS == BFS_DONE."
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8504075 -
Flags: review?(terrence)
Assignee | ||
Comment 2•10 years ago
|
||
The situation is worse than I thought, but I think we're okay after this patch. See also bug 1080584 comment #23, in particular point (4). Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=787612d4fc79
Updated•10 years ago
|
Attachment #8504075 -
Flags: review?(terrence) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Carrying forward r=terrence. Updated the comment and description to better reflect what's actually going on.
Attachment #8504075 -
Attachment is obsolete: true
Attachment #8504160 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f9faedda0179
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f9faedda0179
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•