Reassigning constant in marionette-frame-manager.js:9

RESOLVED INVALID

Status

RESOLVED INVALID
4 years ago
4 years ago

People

(Reporter: ato, Unassigned, Mentored)

Tracking

({pi-marionette-server})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][language=js])

(Reporter)

Description

4 years ago
The FRAME_SCRIPT constant is being reassigned at testing/marionette/marionette-frame-manager.js:9, causing a TypeError.  This causes a JavaScript strict warning that is observable in gecko.log or `adb logcat | grep -i Marionette`.
(Reporter)

Updated

4 years ago
Whiteboard: [good first bug] [mentor=ato]
Keywords: ateam-marionette-server
Whiteboard: [good first bug] [mentor=ato] → [good first bug][language=py]
Whiteboard: [good first bug][language=py] → [good first bug][language=js]

Comment 1

4 years ago
Hi,

I would like to work on it. How should I proceed further?

Thanks
shreyas
Flags: needinfo?(dburns)
hey, sorry for taking so long, I think Andreas would be a better person to handle this so redirecting the need-info
Flags: needinfo?(dburns) → needinfo?(ato)
(Reporter)

Comment 3

4 years ago
I had a closer look at this and it's a difficult bug to fix.  Basically marionette-frame-manager.js gets loaded as a subscript, sometimes multiple times in the same browser, which overwrites global variables.

The right solution would be to make the file a JS module, but this can't be done the way it's currently coded because of the global variables for storing remote frames near the top of the file.

I feel perhaps this bug is wrong and that we should file a more generic bug towards fixing up all of marionette-frame-manager.js.  Therefore I'm closing it.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(ato)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.