Closed Bug 1082008 Opened 6 years ago Closed 5 years ago

Reassigning constant in marionette-frame-manager.js:9

Categories

(Testing :: Marionette, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: ato, Unassigned, Mentored)

Details

(Keywords: pi-marionette-server, Whiteboard: [good first bug][language=js])

The FRAME_SCRIPT constant is being reassigned at testing/marionette/marionette-frame-manager.js:9, causing a TypeError.  This causes a JavaScript strict warning that is observable in gecko.log or `adb logcat | grep -i Marionette`.
Whiteboard: [good first bug] [mentor=ato]
Whiteboard: [good first bug] [mentor=ato] → [good first bug][language=py]
Whiteboard: [good first bug][language=py] → [good first bug][language=js]
Hi,

I would like to work on it. How should I proceed further?

Thanks
shreyas
Flags: needinfo?(dburns)
hey, sorry for taking so long, I think Andreas would be a better person to handle this so redirecting the need-info
Flags: needinfo?(dburns) → needinfo?(ato)
I had a closer look at this and it's a difficult bug to fix.  Basically marionette-frame-manager.js gets loaded as a subscript, sometimes multiple times in the same browser, which overwrites global variables.

The right solution would be to make the file a JS module, but this can't be done the way it's currently coded because of the global variables for storing remote frames near the top of the file.

I feel perhaps this bug is wrong and that we should file a more generic bug towards fixing up all of marionette-frame-manager.js.  Therefore I'm closing it.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(ato)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.