Closed Bug 1082073 Opened 10 years ago Closed 7 years ago

[Messages] Use promises when resizing images

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: julienw, Assigned: julienw)

References

Details

Attachments

(1 file)

github PR
46 bytes, text/x-github-pull-request
steveck
: feedback+
Details | Review 
This is a spin off of Bug 1071514. I wrote this code initially but then I didn't really need it to fix Bug 107514. So it's probably better to extract it in its own Bug.
Attached file github PR — 

        Attachment #8504182 -
        Flags: feedback?(felash)

    
  

        Attachment #8504182 -
        Flags: feedback?(felash) → feedback?(schung)

    
    

    
  
Comment on attachment 8504182 [details] [review]
github PR

Migrating the callback base to Promise looks great, only some nit and concern about the toBlob function.

        Attachment #8504182 -
        Flags: feedback?(schung) → feedback+

    
  
Blocks: sms-refactoring

    
    

    
  
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX

    
    

    
  
Mass closing of Gaia::SMS bugs. End of an era :(

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: