1082099 - Add menus for all refs

Status: RESOLVED FIXED

(Webtools Graveyard :: DXR, defect)

Description

[Erik Rose [:erik][:erikrose]]

For instance, variable refs, namespace refs, etc.

Comment 1

[[github robot]]

Commit pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/4c8b1dfb288c14ca2724ba026c957174e870a209
Add menus to variable references. Reference bug 1082099.

Comment 2

[[github robot]]

Commits pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/bd11c72f12b0c800ed00b37b34c2f218c802f429
Add tests for type and type-ref menus. Reference bug 1082099.

https://github.com/mozilla/dxr/commit/4b1385d9ac7a9a5447919586a86b7614c46d1d7f
Fix menus for declarations of structs, classes, enums, functions, etc. Ref bug 1082099.

* Change the name of declloc field in decldef CSV lines to just "loc". Unlike most other kinds of lines with decllocs, decldef ones don't also have a plain old "loc". This change makes process_loc kick in and extract the loc, combine it with the extent, and make a 'span' key, so the menus get made.
* Remove the Extent-constructing line from process_defloc(). It was doing the wrong thing, putting ints rather than Positions into the Extent. Now process_loc() kicks in for decldef lines (which are the only kind with a defloc) and takes care of the extent field, turning it into a 'span' field.

Comment 3

[[github robot]]

Commit pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/c948fbe609320dd61dcf5135e2e27079dab05b36
Add tests for typedef refs and type refs. Ref bug 1082099.

What we had as a type ref test before was really a typedef ref test.

Btw, "Jump to definition" really does jump to the definition--at least of classes--not to the declaration.

Comment 4

[[github robot]]

Commits pushed to es at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/6f772c12ad80091904a9483ba22f394e8dc639b4
Add tests for namespace and namespace-ref menus. Ref bug 1082099.

https://github.com/mozilla/dxr/commit/af52639ded9aa7048e6da004b683468c92dbae63
Add tests for namespace alias and namespace alias ref menus. Ref bug 1082099.

https://github.com/mozilla/dxr/commit/485445c3fcae33d6bc127571a2ccc91d3dab8ca4
Add tests for macro and macro-ref menus. Fix bug 1082099.

That completes the tests for all menus!

Tweak menu_on() to tolerate the title attr of the macro menu's <a> tag.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/dxr

https://github.com/mozilla/dxr/commit/4c8b1dfb288c14ca2724ba026c957174e870a209
Add menus to variable references. Reference bug 1082099.

https://github.com/mozilla/dxr/commit/bd11c72f12b0c800ed00b37b34c2f218c802f429
Add tests for type and type-ref menus. Reference bug 1082099.

https://github.com/mozilla/dxr/commit/4b1385d9ac7a9a5447919586a86b7614c46d1d7f
Fix menus for declarations of structs, classes, enums, functions, etc. Ref bug 1082099.

https://github.com/mozilla/dxr/commit/c948fbe609320dd61dcf5135e2e27079dab05b36
Add tests for typedef refs and type refs. Ref bug 1082099.

https://github.com/mozilla/dxr/commit/6f772c12ad80091904a9483ba22f394e8dc639b4
Add tests for namespace and namespace-ref menus. Ref bug 1082099.

https://github.com/mozilla/dxr/commit/af52639ded9aa7048e6da004b683468c92dbae63
Add tests for namespace alias and namespace alias ref menus. Ref bug 1082099.

https://github.com/mozilla/dxr/commit/485445c3fcae33d6bc127571a2ccc91d3dab8ca4
Add tests for macro and macro-ref menus. Fix bug 1082099.