1082116 - [Camera] Face detection does not work after touch focus

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20141013_FaceDetection6.txt

Description:
Once the user taps the screen to focus on viewfinder, camera does not detect faces anymore.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141013001201.
2) Open Camera app, and tap an area in the viewfinder screen.
>> The focus is set to the tapped area, and the circle turns green and disappears.
3) Now point the camera towards a human face.
  
Actual:
Face detection circle does NOT appear.  

Expected: 
A circle appears to identify the face.

Note:
Face detection can be restored by taking a photo or re-opening the Camera app.
  
Environmental Variables:
Device: Flame 2.1
BuildID: 20141013001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/14690/
See attached: logcat, video
http://youtu.be/vhKyWdqTrUw

Comment 1

[Yeojin Chung [:YeojinC]]

This issue does reproduce on Flame 2.2:

Device: Flame 2.2 Master KK (319mb) (Full Flash)
BuildID: 20141013040202
Gaia: 3b81896f04a02697e615fa5390086bd5ecfed84f
Gecko: f547cf19d104
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Face detection circle does NOT appear after touch focus.

---------------------------------------------------
This issue does NOT reproduce on Flame 2.0:

Device: Flame 2.0 KK (319mb) (Full Flash)
BuildID: 20141013000204
Gaia: 6effca669c5baaf6cd7a63c91b71a02c6bd953b3
Gecko: 54ec9cb26b59
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 32.0 (2.0)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Face detection circle appears consistently after touch focus.

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Face detection and tap-to-focus are mutually-exclusive features.

I believe face detection should resume after ~10s if you don't take a picture.

Comment 3

[Diego Marcos [:dmarcos]]

Attachment: Pull Request

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8505255 [details] [review]
Pull Request

One minor nit, but otherwise LGTM!

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a regression and bad functionality so nominating 2.1?

Comment 6

[Diego Marcos [:dmarcos]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/8c7660bc5e01f934e3c692b3efb8547848695f36

Comment 7

[Hema Koka [:hema]]

Blocking Reason: Regression

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.1 approval on this when you get a chance :)

Comment 9

[Diego Marcos [:dmarcos]]

Comment on attachment 8505255 [details] [review]
Pull Request

[User impact] if declined:
Face tracking does not work properly on video mode

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/5e879596967d61358d9149ff26a81ffa5ac8d11d

Comment 11

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2 and 2.1.
The face detection circle appears after the user taps the screen to focus. HOWEVER, it takes several seconds for the face detection circle to appear on Flame 2.2 and 2.1, whereas it appears immediately on 2.0.

Flame 2.2 

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141022040201
Gaia: 4d7f051cede6544f4c83580253c743c22b0cb279
Gecko: ae4d9b4ff2ee
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141022001201
Gaia: 3d9cc667f4e929861a9a77c41096bbf5a9c1bde0
Gecko: 928b18f7d8ff
Gonk: 05aa7b98d3f891b334031dc710d48d0d6b82ec1d
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.

Comment 12

[Yeojin Chung [:YeojinC]]

Filed a new bug 1088290 for the issue mentioned in Comment 11.