1082135 - [HomeScreen] Edit header button is the wrong color

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Screenshot of problem

Comment 2

[Kevin Grandon :kgrandon]

It turns out that there is multiple issues while bisecting when trying to find a working commit. The other issue is that the header loses it's "theme" CSS, so this might need a full bisect. Bisecting both issues on gaia leads to "Update links to fetch gaia-theme from default theme.". This is bug 1069840 I believe.

$ git bisect start
$ git bisect bad 4f86c631e0465c0e56ccebeb1324fd28be9ea32f
$ git bisect good 6318d7923760d071bd1faa5258e5244777b5d33e
Bisecting: 154 revisions left to test after this (roughly 7 steps)
[8e107e1b26f03f002ac262c0b9db0317d7185c1b] Merge pull request #24928 from timdream/softbutton-focus

$ git bisect bad
Bisecting: 76 revisions left to test after this (roughly 6 steps)
[71a6d32f9a0c1dbce06cf3a191a67d046b9771f0] Merge pull request #24887 from Rik/redial-outgoing-1078921

$ git bisect good
Bisecting: 38 revisions left to test after this (roughly 5 steps)
[23a3f5475a94442a620559fb9033e373d9926f06] Merge pull request #24500 from KevinGrandon/bug_971480_systemv2_cost_control

$ git bisect good
Bisecting: 19 revisions left to test after this (roughly 4 steps)
[b0e9fd9ffa8d7a727c1976365f0ff0262eabfb1a] Merge pull request #24792 from KevinGrandon/bug_971469_system2_instantiable_battery_manager

$ git bisect bad
Bisecting: 9 revisions left to test after this (roughly 3 steps)
[8ad2e1c5460edc99f69e0ab28a217cd646514fc9] Revert "Merge pull request #24874 from jmcanterafonseca/fix_settings_animation"

$ git bisect bad
Bisecting: 4 revisions left to test after this (roughly 2 steps)
[cdf54e571cca86f67d0ce0488e9fe0c70b18d1f2] Merge pull request #24658 from mancas/bug1026306

$ git bisect good
Bisecting: 2 revisions left to test after this (roughly 1 step)
[a8e94695b841e3be4d5b80a757c716b7de397ae4] Merge pull request #24654 from oklang/Update-links-to-fetch-shared-style-from-default-theme

$ git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[2896d5ff8e3b531c3d26b216102ebe55f0cfb5d0] Update links to fetch gaia-theme from default theme.

$ git bisect bad
2896d5ff8e3b531c3d26b216102ebe55f0cfb5d0 is the first bad commit
commit 2896d5ff8e3b531c3d26b216102ebe55f0cfb5d0
Author: Olle Klang <[e-mail]>
Date:   Tue Sep 30 15:54:16 2014 +0200

    Update links to fetch gaia-theme from default theme.

:040000 040000 d6321ed10fe26a9b63ebc8be8c54e87bc9eba0b4 4a1376f9fb29e1ed1e49683c556e5d653ee96733 M	apps

Comment 3

[Kevin Grandon :kgrandon]

Possibly also caused by bug 1076907.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Gaia-theme pull request

Wilson - could you review this? This restores the original blue color of header buttons before the recent gaia-theme patch landed. Thanks!

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Gaia pull request to bump version - WIP

Obviously need to wait for the gaia-theme updates to land.

Comment 6

[Wilson Page [:wilsonpage]]

Comment on attachment 8504288 [details] [review]
Gaia-theme pull request

Thanks for catching this :)

Comment 7

[Wilson Page [:wilsonpage]]

Gaia-theme v0.4.3 https://github.com/gaia-components/gaia-theme/releases/tag/v0.4.3

Comment 8

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8504580 [details] [review]
pull-request (master)

Thanks!

Comment 10

[Kevin Grandon :kgrandon]

https://github.com/mozilla-b2g/gaia/commit/288e20352555c906fdc81a6a35dfa1430cd63666