Closed
Bug 1082152
Opened 10 years ago
Closed 9 years ago
switch "size" arguments to "shard_size" for ES facet calls
Categories
(Input Graveyard :: Code Quality, defect)
Input Graveyard
Code Quality
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: willkg, Unassigned)
Details
(Whiteboard: u=user c=dashboard p= s=)
Bug #940361 covered an accuracy problem. I created PR #366 <https://github.com/mozilla/fjord/pull/366> to add a size argument to the facet calls and in doing so, fix the accuracy problems. Erik pointed out we should be using shard_size rather than size in his PR comment <https://github.com/mozilla/fjord/pull/366#issuecomment-58944729>. This bug covers switching from "size" to "shard_size". There are a couple of options: 1. switch to facet_raw() so we can pass in the additional parameter 2. add support to ElasticUtils for a shard_size parameter Sticking it in this quarter so I remember to check performance after pushing this out to see if we should make this change sooner rather than later.
Reporter | ||
Comment 1•10 years ago
|
||
Pushing this to next quarter.
Whiteboard: u=user c=dashboard p= s=input.2014q4 → u=user c=dashboard p= s=input.2015q1
Reporter | ||
Comment 2•9 years ago
|
||
The third option is that we implement this when we switch to elasticsearch-dsl-py which might happen after we get to Elasticsearch >= 1.0. I don't think that's going to happen any time soon. I'm going to bump it out of this quarter.
Whiteboard: u=user c=dashboard p= s=input.2015q1 → u=user c=dashboard p= s=
Reporter | ||
Comment 3•9 years ago
|
||
We switched from facets to aggregations when we switched to elasticsearch-dsl. So this isn't relevant anymore. Closing as WONTFIX.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Assignee | ||
Updated•7 years ago
|
Product: Input → Input Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•