Closed
Bug 1082172
Opened 10 years ago
Closed 10 years ago
Use driver provided event timestamps on JB and newer
Categories
(Core Graveyard :: Widget: Gonk, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: mwu, Assigned: mwu)
Details
Attachments
(1 file)
715 bytes,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
EventHub.cpp can give us monotonic driver timestamps with Linux kernels 3.4 and newer. Those kernels can be expected on JB and newer devices. This patch enables the appropriate code on anything that isn't ICS.
Attachment #8504304 -
Flags: review?(bugmail.mozilla)
Comment 1•10 years ago
|
||
Comment on attachment 8504304 [details] [diff] [review] Use driver provided event timestamps on JB and newer Review of attachment 8504304 [details] [diff] [review]: ----------------------------------------------------------------- Mostly rubber-stamping. I looked at the relevant code that is enabled by this and it looks sane. Do you expect any potential regressions from this? Anything we should watch out for?
Attachment #8504304 -
Flags: review?(bugmail.mozilla) → review+
Assignee | ||
Comment 2•10 years ago
|
||
The main thing I was worried about here is misbehavior on kernels that don't support this. All actual devices running JB 4.3 or newer should have Linux 3.4 or newer, but I'm not sure our JB/KK emulators run upgraded kernels. There is a sanity check which should at least ensure it won't misbehave too much, but I don't know if it's enough.
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/5eb54b0e4e07
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5eb54b0e4e07
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•