JS errors prevent page from loading when using production API

VERIFIED FIXED in 2014-10-14

Status

Marketplace
Consumer Pages
P1
normal
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: cvan, Assigned: mat)

Tracking

2014-10-14
Points:
---

Details

(Whiteboard: [repoman], URL)

(Reporter)

Description

3 years ago
NOTE: Not a huge deal in itself. But this bug will occur in production if Fireplace is pushed before Zamboni. If we go about our normal push schedule, this will happen - because Zamboni takes so long to update, Fireplace will be hitting the old API for ~10 minutes.

So we should either make this change backwards compatible with the API, or we should ensure that Zamboni is pushed before pushing Fireplace. I'm leaning towards the former, but let's pick one.

––

1. Fire up Fireplace's damper
2. Change your `settings_local.js` to point to prod's API URL:

    define('settings_local', [], function() {
        return {
            api_url: 'https://marketplace.firefox.com',
            media_url: 'https://marketplace.cdn.mozilla.net/media/',
        };
    });

3. Load http://localhost:8675
4. Notice the errors

https://www.dropbox.com/s/409mdp8m4zc8ad5/Screenshot%202014-10-13%2014.34.06.png?dl=0

https://www.dropbox.com/s/4igfu64r5hfnbtf/Screenshot%202014-10-13%2014.42.57.png?dl=0

https://github.com/mozilla/fireplace/blob/master/src/media/js/commonplace/site_config.js

––

Not reproducible with -dev's API URL.

––
(Reporter)

Updated

3 years ago
Summary: JS errors prevent page from loading when using Marketplace API → JS errors prevent page from loading when using production API
(Assignee)

Comment 1

3 years ago
Your first error was fixed in https://github.com/mozilla/fireplace/commit/60a77b2e1ccae532191d5c40942d281111f0bd24

Going to submit a simple patch for the second one as I just hit that today.
Status: NEW → ASSIGNED
Target Milestone: --- → 2014-10-14
(Assignee)

Updated

3 years ago
Assignee: nobody → mpillard
(Assignee)

Updated

3 years ago
Whiteboard: [repoman]
(Assignee)

Comment 2

3 years ago
Fixed in https://github.com/mozilla/fireplace/commit/bc534f051930fbe7f005e892cba22c915e436776
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 3

3 years ago
So, I loaded Marketplace.firefox.com and browsed through the pages after Fireplace was pushed (before Zamboni was updated)

No JS errors.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.