Closed
Bug 1082196
Opened 10 years ago
Closed 10 years ago
ImportError when running loop tests following change to marionette's mach script
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox35 fixed, firefox36 fixed)
RESOLVED
FIXED
mozilla36
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file)
1.13 KB,
patch
|
dmosedale
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The changes in bug 1050511 invalidated the imports in test_1_browser_call.py when running through mach. I didn't catch this before landing because the manifest for that directory isn't included in marionette's unit-tests.ini, which isn't included in marionette's unit-tests.ini, which is what is run by mach with no arguments, which is what I ran to test my patch.
Assignee | ||
Comment 1•10 years ago
|
||
This resolves the imports, although the test still fails running locally with something that looks unrelated.
Attachment #8504327 -
Flags: review?(dmose)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → cmanchester
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Yeah, the test currently requires some external set up to work right. Happily, this patches fixes things up quite nicely; thanks!
Comment 3•10 years ago
|
||
Comment on attachment 8504327 [details] [diff] [review] Update imports in test files to reflect changes to mach's marionette script made in bug 1050511. Review of attachment 8504327 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for the patch!
Attachment #8504327 -
Flags: review?(dmose) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 4•10 years ago
|
||
Hi, do we need a try run here to make sure everything works ?
Keywords: checkin-needed
Comment 5•10 years ago
|
||
(In reply to Carsten Book [:Tomcat] from comment #4) > Hi, do we need a try run here to make sure everything works ? No, the test this fixes isn't yet run on automation.
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7edf7615f2f4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment 8•10 years ago
|
||
Comment on attachment 8504327 [details] [diff] [review] Update imports in test files to reflect changes to mach's marionette script made in bug 1050511. Approval Request Comment Landed on aurora per IRC with lsblakk with a=loop-only
Attachment #8504327 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8504327 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Updated•10 years ago
|
status-firefox35:
--- → fixed
status-firefox36:
--- → fixed
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•