1082220 - [Dialer] Done button in dialer contacts page is always highlighted, making it barely visible

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Rachel Pribble [:rpribble]]

Attachment: Screenshot.png

Description:
The 'done' button in the upper right of the dialer contacts page remains always highlighted, making it nearly impossible for the user to see and utilize.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141013040202
2) Dialer > tap contacts tab > settings button in upper right
3) Observe 'done' in upper right barely visible
  
Actual:
'Done' button in dialer contacts tab settings page is always highlighted and hard to see.
  
Expected: 
'Done' is not highlighted until the user taps it.
  
Environmental Variables:
Device: Flame 2.2 Master KK (319 MB)
BuildID: 20141013040202 (full flash)
Gaia: 3b81896f04a02697e615fa5390086bd5ecfed84f
Gecko: f547cf19d104
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0
  
Notes:
  
Repro frequency: 5/5
See attached: Screenshot, logcat

Comment 1

[Rachel Pribble [:rpribble]]

Attachment: Logcat.txt

Attaching logcat.

Comment 2

[Rachel Pribble [:rpribble]]

Adding qawanted to check v2.1. Thank you!

Comment 3

[Joshua Mitchell (Inactive)]

Attachment: 2014-10-14-02-06-13.png

Comment 4

[Joshua Mitchell (Inactive)]

Issue is not present in 2.1 due to different layouts (so not considering this a regression, but a design difference) - in 2.1 the header where the 'done' button is located in white making the blue 'done' button easy to see as opposed to 2.2 where it is a blue 'done' button on a blue header field. 

Environmental Variables:
Device: Flame 2.1 (KK - Full-Flash - Nightly)
BuildID: 20141013001201
Gaia: d18e130216cd3960cd327179364d9f71e42debda
Gecko: 610ee0e6a776
Version: 34.0a2 (2.1) 
Firmware Version: V184
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 5

[Johan Lorenzo [:jlorenzo]]

Carrie, do we know what will be the color of the "Done" text in 2.2?

Comment 6

[Gabriele Svelto [:gsvelto]]

Attachment: 2014-10-14-08-39-41.png

I noticed this issue in the SMS app too, when deleting messages the "Select All" button (see attachment) so I made a quick bisection and it turns out that the problem was caused by the shared gaia header component and introduced in bug 1076907.

Comment 7

[Gabriele Svelto [:gsvelto]]

needinfo'ing Wilson Page who landed those changes. The problem stems from the fact that the old header had a white-ish background with light blue fonts while the new one has a blue-ish background making the button's light blue font almost invisibile.

Comment 8

[Carrie Wang [New account: [e-mail]]]

ni? Fang for visual issue. Thanks!

Comment 9

[Wilson Page [:wilsonpage]]

Attachment: dialer-edit-mode (fixed)

Fixed yesterday by bug 1081126

Comment 10

[Fang Shih [:fang]]

Attachment: Header Color.png

Attached the header spec. If the header is in setting, then the "Done" button should be blue, if the header is in comms teal then "done" should be in darker teal. I just want to make sure these headers are using the common component from Building Blocks right now. So when the final 2.2 component release, then we can have it automatically follow up the newest color. Hope this helps! Please let me know if you have any other questions. Thanks!

Comment 11

[Wilson Page [:wilsonpage]]

(In reply to Fang Shih [:grasspizza] from comment #10)
> Created attachment 8506020 [details]
> Header Color.png
> 
> Attached the header spec. If the header is in setting, then the "Done"
> button should be blue, if the header is in comms teal then "done" should be
> in darker teal. I just want to make sure these headers are using the common
> component from Building Blocks right now. So when the final 2.2 component
> release, then we can have it automatically follow up the newest color. Hope
> this helps! Please let me know if you have any other questions. Thanks!

The spec (attachment 8506020 [details]) is out of date, the dark boxes in the pressed state were dropped in v2.1. Also the headers.css build-block was deprecated in v2.1 in favour of the gaia-header web-component. I'm working closely with Przemek to make sure that all new components align with the latest visual specs.