1082225 - WebGL: Fix bogus assert validating mStencilBufferRefFront/Back

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

We're caching a value that is clamped internally, but not reading back the cached version as clamped.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1082225-bogus-clamp-assert.patch

Comment 2

[Kelsey Gilbert [:jgilbert]]

This is actually a dupe of 1015561.
Let's just take the pre-r+'d patch there.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8504366 [details] [diff] [review]
bug1082225-bogus-clamp-assert.patch

Review of attachment 8504366 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLContext.h
@@ +1319,5 @@
>      GLfloat mColorClearValue[4];
>      GLint mStencilClearValue;
>      GLfloat mDepthClearValue;
>  
> +    GLint ClampStencilRef(GLint ref);

We don't want to expose this publically, since it's really just for our assertions, and surprisingly calls into GL instead of just recovering our expected values.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix-clamp-assert.patch

Looks like it's an actual int to GL, so it needs clamping rather than masking.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix-clamp-assert.patch

(w/ stray bits removed)

Comment 6

[Kelsey Gilbert [:jgilbert]]

This code was removed.